Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1849423002:
Verify that Update 2 of VS 2015 is used to build Chromium (Closed)
|
Created:
4 years, 8 months ago by brucedawson Modified:
4 years, 7 months ago CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionVerify that Update 2 of VS 2015 is used to build Chromium
It is easy to accidentally build Chromium with an earlier version of
Visual Studio, but earlier versions have bugs and differences that can
lead to problems and cause confusion.
BUG=440500
Committed: https://crrev.com/c833e65d0234f6f8950b46f5c54e083d024a26bd
Cr-Commit-Position: refs/heads/master@{#390494}
Patch Set 1 #
Messages
Total messages: 21 (6 generated)
brucedawson@chromium.org changed reviewers: + thakis@chromium.org
What do you think about this? And, is it worth landing this now, before VS 2015 is 'officially' required? It might be worth it because even now we don't want people wasting time using compilers with known bugs. I'm surprised we never had checks for Update 4 of VS 2013.
I think this is fine in principle, but I wouldn't land it today, given that update 2 has been out like a day and people probably need a bit longer than that to upgrade.
On 2016/04/01 21:25:54, Nico wrote: > I think this is fine in principle, but I wouldn't land it today, given that > update 2 has been out like a day and people probably need a bit longer than that > to upgrade. Agreed. No need to be abusive to our external developers :-)
brucedawson@chromium.org changed reviewers: + laforge@chromium.org
If we are going to start depending on VS 2015 then we should require that developers use Update 2, to avoid spurious failures like the ANGLE team hit last week. This change checks for a minimum of VS 2015 Update 2, in base. This change doesn't need to be landed immediately and might be best preceded by an email to chromium-dev@ so that nobody is surprised and everybody gets a chance to comment.
The CQ bit was checked by danakj@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849423002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Okie, can you send a "we now require 2015 update 2, and we'll land an explicit compiler check for that in 2 weeks." mail to chromium-dev? After that, lgtm to land in 2 weeks.
(maybe 'we require 2015 starting today, and will check for update 2 in 2 weeks')
On Tue, Apr 12, 2016 at 2:41 PM, <thakis@chromium.org> wrote: > (maybe 'we require 2015 starting today, and will check for update 2 in 2 > weeks') > +1 -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/04/12 21:41:42, Nico wrote: > (maybe 'we require 2015 starting today, and will check for update 2 in 2 weeks') I think it's better to say we require Update 2 now, but won't enforce it immediately. There's no reason to stay on Update 1 that I am aware of.
On Tue, Apr 12, 2016 at 2:43 PM, <brucedawson@chromium.org> wrote: > On 2016/04/12 21:41:42, Nico wrote: > > (maybe 'we require 2015 starting today, and will check for update 2 in 2 > weeks') > > I think it's better to say we require Update 2 now, but won't enforce it > immediately. There's no reason to stay on Update 1 that I am aware of. > Oh, I +1'd and missed that subtlety. It's not like we check for Update 1 today, or intend to support code that works in U1 but not U2, so saying Update 2 is required sounds right to me. -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
Yes, that's what I tried to say too. On Apr 12, 2016 5:46 PM, "Dana Jansens" <danakj@chromium.org> wrote: > On Tue, Apr 12, 2016 at 2:43 PM, <brucedawson@chromium.org> wrote: > >> On 2016/04/12 21:41:42, Nico wrote: >> > (maybe 'we require 2015 starting today, and will check for update 2 in 2 >> weeks') >> >> I think it's better to say we require Update 2 now, but won't enforce it >> immediately. There's no reason to stay on Update 1 that I am aware of. >> > > Oh, I +1'd and missed that subtlety. It's not like we check for Update 1 > today, or intend to support code that works in U1 but not U2, so saying > Update 2 is required sounds right to me. > -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
The CQ bit was checked by brucedawson@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849423002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c833e65d0234f6f8950b46f5c54e083d024a26bd Cr-Commit-Position: refs/heads/master@{#390494}
Message was sent while issue was closed.
Description was changed from ========== Verify that Update 2 of VS 2015 is used to build Chromium It is easy to accidentally build Chromium with an earlier version of Visual Studio, but earlier versions have bugs and differences that can lead to problems and cause confusion. BUG=440500 ========== to ========== Verify that Update 2 of VS 2015 is used to build Chromium It is easy to accidentally build Chromium with an earlier version of Visual Studio, but earlier versions have bugs and differences that can lead to problems and cause confusion. BUG=440500 Committed: https://crrev.com/c833e65d0234f6f8950b46f5c54e083d024a26bd Cr-Commit-Position: refs/heads/master@{#390494} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
