Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849403003: [gmscore] Allow specifying resource files to whitelist for preprocess (Closed)

Created:
4 years, 8 months ago by dgn
Modified:
4 years, 8 months ago
Reviewers:
whywhat, agrieve
CC:
whywhat, chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gmscore] Allow specifying resource files to whitelist for preprocess BUG=599954 Committed: https://crrev.com/577d5e394ee173323c0df50d451e379e76e37b6a Cr-Commit-Position: refs/heads/master@{#386970}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add pathname pattern support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M build/android/play_services/preprocess.py View 1 3 chunks +13 lines, -2 lines 0 comments Download
M build/android/play_services/utils.py View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dgn
PTAL
4 years, 8 months ago (2016-04-01 21:14:20 UTC) #2
agrieve
On 2016/04/01 21:14:20, dgn wrote: > PTAL sorry, missed this. lgtm!
4 years, 8 months ago (2016-04-07 00:42:15 UTC) #3
whywhat
lgtm https://codereview.chromium.org/1849403003/diff/1/build/android/play_services/utils.py File build/android/play_services/utils.py (right): https://codereview.chromium.org/1849403003/diff/1/build/android/play_services/utils.py#newcode68 build/android/play_services/utils.py:68: - resource_whitelist Could you please also support * ...
4 years, 8 months ago (2016-04-12 16:00:16 UTC) #5
dgn
PTAL https://codereview.chromium.org/1849403003/diff/1/build/android/play_services/utils.py File build/android/play_services/utils.py (right): https://codereview.chromium.org/1849403003/diff/1/build/android/play_services/utils.py#newcode68 build/android/play_services/utils.py:68: - resource_whitelist On 2016/04/12 16:00:16, whywhat wrote: > ...
4 years, 8 months ago (2016-04-12 16:31:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849403003/20001
4 years, 8 months ago (2016-04-13 11:10:09 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-13 12:11:56 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-13 12:13:34 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/577d5e394ee173323c0df50d451e379e76e37b6a
Cr-Commit-Position: refs/heads/master@{#386970}

Powered by Google App Engine
This is Rietveld 408576698