Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 1849403002: Update PolymerElements/iron-a11y-keys-behavior for ESC key fix (Closed)

Created:
4 years, 8 months ago by michaelpg
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-polymer_chromium.org, oshima+watch_chromium.org, michaelpg+watch-polymer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update PolymerElements/iron-a11y-keys-behavior for ESC key fix This fixes the ESC key in chrome://md-settings. It also fixes downloads.html when using -Duse_vulcanize=0. A follow-up patch will need to re-run vulcanize/crisper. R=dbeam@chromium.org BUG=599373 Committed: https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e Cr-Commit-Position: refs/heads/master@{#384791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -138 lines) Patch
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/.bower.json View 2 chunks +8 lines, -8 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/CONTRIBUTING.md View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/README.md View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/bower.json View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/index.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-a11y-keys-behavior/iron-a11y-keys-behavior-extracted.js View 4 chunks +18 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/.bower.json View 2 chunks +6 lines, -5 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/bower.json View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/polymer/v1_0/components-chromium/iron-test-helpers/iron-test-helpers-extracted.js View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/mock-interactions.js View 11 chunks +197 lines, -85 lines 0 comments Download
M third_party/polymer/v1_0/components-chromium/iron-test-helpers/test-helpers.js View 6 chunks +14 lines, -6 lines 0 comments Download
M ui/webui/resources/polymer_resources.grdp View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
michaelpg
PTAL. I'm having trouble with the output of vulcanize.py, can you give it a try ...
4 years, 8 months ago (2016-04-01 20:46:23 UTC) #1
Dan Beam
On 2016/04/01 20:46:23, michaelpg wrote: > PTAL. I'm having trouble with the output of vulcanize.py, ...
4 years, 8 months ago (2016-04-01 21:15:17 UTC) #2
Dan Beam
lgtm, but i still find ^thing$.test(something) silly, as it's equivalent to something == 'thing'
4 years, 8 months ago (2016-04-02 01:53:43 UTC) #3
michaelpg
On 2016/04/02 01:53:43, Dan Beam wrote: > lgtm, but i still find > > ^thing$.test(something) ...
4 years, 8 months ago (2016-04-02 02:31:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849403002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849403002/1
4 years, 8 months ago (2016-04-02 02:31:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-02 03:32:06 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-02 03:33:29 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13871d3b9ac20123bd17ecd748e55aaa476d008e
Cr-Commit-Position: refs/heads/master@{#384791}

Powered by Google App Engine
This is Rietveld 408576698