Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 18494: Added a dialog for removing exceptions of password manager (Closed)

Created:
10 years, 7 months ago by Alpha Left Google
Modified:
8 years, 1 month ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

BUG=1007 Added a dialog for removing exceptions of password manager Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog.

Patch Set 1 #

Patch Set 2 : Reusing PasswordManagerTableModel #

Total comments: 7

Patch Set 3 : fixing typo in content_page_view.cc #

Patch Set 4 : style nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+381 lines, -6 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/views/browser_views.vcproj View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/views/options/content_page_view.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/views/options/content_page_view.cc View 1 2 5 chunks +19 lines, -2 lines 0 comments Download
A chrome/browser/views/password_manager_exceptions_view.h View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
A chrome/browser/views/password_manager_exceptions_view.cc View 1 2 3 1 chunk +243 lines, -0 lines 0 comments Download
M chrome/browser/views/password_manager_view.h View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Alpha Left Google
Tim, The exceptions dialog is up for review. :)
10 years, 7 months ago (2009-01-22 10:33:30 UTC) #1
tim (not reviewing)
On 2009/01/22 10:33:30, Alpha wrote: > Tim, > > The exceptions dialog is up for ...
10 years, 6 months ago (2009-01-22 18:06:55 UTC) #2
tim (not reviewing)
http://codereview.chromium.org/18494/diff/14/19 File chrome/browser/views/password_manager_exceptions_view.cc (right): http://codereview.chromium.org/18494/diff/14/19#newcode30 Line 30: ::PasswordManagerExceptionsTableModel(Profile* profile) nit - I would do PasswordManagerExceptionsTableModel::PasswordManagerExceptionsTableModel( ...
10 years, 6 months ago (2009-01-22 19:55:27 UTC) #3
tim (not reviewing)
10 years, 6 months ago (2009-01-23 02:02:39 UTC) #4
LGTM
exciting.

Powered by Google App Engine
This is Rietveld 408576698