Added a dialog for removing exceptions of password manager

BUG=1007
Added a dialog for removing exceptions of password manager
Added the PasswordManagerExceptionsView class for removing exception of password manager added by "Never for this site" button. Also added a button in "Minor Tweaks" tab for openning the dialog.

[Alpha Left Google, 2009-01-22 10:33:30]

Tim,

  The exceptions dialog is up for review. :)

[tim (not reviewing), 2009-01-22 18:06:55]

On 2009/01/22 10:33:30, Alpha wrote:
> Tim,
> 
>   The exceptions dialog is up for review. :)

OMG, thank you for doing this!
(Please update the change description with a "BUG=1007" line.)

I know we talked about this before, but looking at
password_manager_exceptions_view.h/cc.. it overlaps the PasswrodManagerView
quite a bit...

Seems like the main differences are that we have one less button (no Show
Password), and of course the ButtonPressed impl does different things in each
case. So the View itself, maybe is best left re-implemented. But really, what's
the difference in a PasswordRow or ExceptionRow? Or
ForgetAndRemoveException/ForgetAndRemoveSignon? Or
GetAllSavedLogins/GetAllLoginsForProfile (we could use
web_data_service->GetAllLogins() in both cases and just filter ourselves)? Now
that you have it actually working (wheras before we were just hypothesizing) how
hard do you think it would be to re-use a bit, maybe at least
PasswordManagerViewTableModel? 

I'm sorry for bringing this up again. But seeing it in code refueled the
questions in my head...

thanks again!

[tim (not reviewing), 2009-01-22 19:55:27]

http://codereview.chromium.org/18494/diff/14/19
File chrome/browser/views/password_manager_exceptions_view.cc (right):

http://codereview.chromium.org/18494/diff/14/19#newcode30
Line 30: ::PasswordManagerExceptionsTableModel(Profile* profile)
nit - I would do 
PasswordManagerExceptionsTableModel::PasswordManagerExceptionsTableModel(

on one line, (73 chars)

http://codereview.chromium.org/18494/diff/14/19#newcode37
Line 37: std::wstring PasswordManagerExceptionsTableModel::GetText(int row, int
col_id) {
we don't really need the extra EXCEPTIONS_VIEW_SITE_COLUMN since it's the same
as VIEW_SITE_COLUMN... and then you wouldn't need to override GetText or
CompareValues.
you could alternatively do
GetText(int row, int col_id) {
DCHECK_NE(col_id, IDS_PASSWORD_MANAGER_VIEW_USERNAME_COL);
PasswordManagerViewTableModel::GetText(row, col_id);
}
or not?

http://codereview.chromium.org/18494/diff/14/19#newcode48
Line 48: int column_id) {
indent

http://codereview.chromium.org/18494/diff/14/19#newcode194
Line 194: views::View* parent,
nit - indent

http://codereview.chromium.org/18494/diff/14/20
File chrome/browser/views/password_manager_exceptions_view.h (right):

http://codereview.chromium.org/18494/diff/14/20#newcode23
Line 23: public:
nit - indent 1 space

http://codereview.chromium.org/18494/diff/14/20#newcode39
Line 39: public views::DialogDelegate,
indent

http://codereview.chromium.org/18494/diff/14/20#newcode63
Line 63: virtual bool CanResize() const;
impl could go on same line for these simple bools

[tim (not reviewing), 2009-01-23 02:02:39]

LGTM
exciting.