content/browser/web_contents/web_contents_impl.cc - Issue 1849343004: Remove RenderFrameHostImplState and convert it to boolean.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1849343004: Remove RenderFrameHostImplState and convert it to boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index fd293b76d5c0957edfc928f5bd130b6cfe5cb72a..53ea8d504e91f54a2bf407541c8e9e9f7ed608a0 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3897,7 +3897,7 @@ void WebContentsImpl::RunBeforeUnloadConfirm(

delegate_->WillRunBeforeUnloadConfirm();

bool suppress_this_message =

- rfhi->rfh_state() != RenderFrameHostImpl::STATE_DEFAULT ||

+ !rfhi->is_active() ||

ShowingInterstitialPage() || !delegate_ ||

delegate_->ShouldSuppressDialogs(this) ||

!delegate_->GetJavaScriptDialogManager(this);

« no previous file with comments | « content/browser/site_per_process_browsertest.cc ('k') | no next file » | no next file with comments »