Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 1849343004: Remove RenderFrameHostImplState and convert it to boolean. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing nits. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stdint.h> 5 #include <stdint.h>
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "base/time/time.h" 8 #include "base/time/time.h"
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 #include "content/browser/frame_host/navigation_controller_impl.h" 10 #include "content/browser/frame_host/navigation_controller_impl.h"
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 // Have the current RenderFrameHost commit the navigation. 144 // Have the current RenderFrameHost commit the navigation.
145 scoped_refptr<ResourceResponse> response(new ResourceResponse); 145 scoped_refptr<ResourceResponse> response(new ResourceResponse);
146 GetLoaderForNavigationRequest(request) 146 GetLoaderForNavigationRequest(request)
147 ->CallOnResponseStarted(response, MakeEmptyStream()); 147 ->CallOnResponseStarted(response, MakeEmptyStream());
148 EXPECT_TRUE(DidRenderFrameHostRequestCommit(main_test_rfh())); 148 EXPECT_TRUE(DidRenderFrameHostRequestCommit(main_test_rfh()));
149 EXPECT_TRUE(main_test_rfh()->is_loading()); 149 EXPECT_TRUE(main_test_rfh()->is_loading());
150 EXPECT_FALSE(node->navigation_request()); 150 EXPECT_FALSE(node->navigation_request());
151 151
152 // Commit the navigation. 152 // Commit the navigation.
153 main_test_rfh()->SendNavigate(0, entry_id, true, kUrl); 153 main_test_rfh()->SendNavigate(0, entry_id, true, kUrl);
154 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, main_test_rfh()->rfh_state()); 154 EXPECT_TRUE(main_test_rfh()->is_active());
155 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl), 155 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl),
156 main_test_rfh()->GetSiteInstance()->GetSiteURL()); 156 main_test_rfh()->GetSiteInstance()->GetSiteURL());
157 EXPECT_EQ(kUrl, contents()->GetLastCommittedURL()); 157 EXPECT_EQ(kUrl, contents()->GetLastCommittedURL());
158 EXPECT_FALSE(node->render_manager()->pending_frame_host()); 158 EXPECT_FALSE(node->render_manager()->pending_frame_host());
159 159
160 // The main RenderFrameHost should not have been changed, and the renderer 160 // The main RenderFrameHost should not have been changed, and the renderer
161 // should have been initialized. 161 // should have been initialized.
162 EXPECT_EQ(site_instance_id, main_test_rfh()->GetSiteInstance()->GetId()); 162 EXPECT_EQ(site_instance_id, main_test_rfh()->GetSiteInstance()->GetId());
163 EXPECT_TRUE(main_test_rfh()->IsRenderFrameLive()); 163 EXPECT_TRUE(main_test_rfh()->IsRenderFrameLive());
164 164
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 // Have the current RenderFrameHost commit the navigation. 197 // Have the current RenderFrameHost commit the navigation.
198 scoped_refptr<ResourceResponse> response(new ResourceResponse); 198 scoped_refptr<ResourceResponse> response(new ResourceResponse);
199 GetLoaderForNavigationRequest(request) 199 GetLoaderForNavigationRequest(request)
200 ->CallOnResponseStarted(response, MakeEmptyStream()); 200 ->CallOnResponseStarted(response, MakeEmptyStream());
201 EXPECT_TRUE(DidRenderFrameHostRequestCommit(main_test_rfh())); 201 EXPECT_TRUE(DidRenderFrameHostRequestCommit(main_test_rfh()));
202 EXPECT_TRUE(main_test_rfh()->is_loading()); 202 EXPECT_TRUE(main_test_rfh()->is_loading());
203 EXPECT_FALSE(node->navigation_request()); 203 EXPECT_FALSE(node->navigation_request());
204 204
205 // Commit the navigation. 205 // Commit the navigation.
206 main_test_rfh()->SendNavigate(1, 0, true, kUrl2); 206 main_test_rfh()->SendNavigate(1, 0, true, kUrl2);
207 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, main_test_rfh()->rfh_state()); 207 EXPECT_TRUE(main_test_rfh()->is_active());
208 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl2), 208 EXPECT_EQ(SiteInstanceImpl::GetSiteForURL(browser_context(), kUrl2),
209 main_test_rfh()->GetSiteInstance()->GetSiteURL()); 209 main_test_rfh()->GetSiteInstance()->GetSiteURL());
210 EXPECT_EQ(kUrl2, contents()->GetLastCommittedURL()); 210 EXPECT_EQ(kUrl2, contents()->GetLastCommittedURL());
211 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node)); 211 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
212 EXPECT_FALSE(node->render_manager()->pending_frame_host()); 212 EXPECT_FALSE(node->render_manager()->pending_frame_host());
213 } 213 }
214 214
215 // PlzNavigate: Test a complete renderer-initiated navigation that should be 215 // PlzNavigate: Test a complete renderer-initiated navigation that should be
216 // cross-site but does not result in a SiteInstance swap because its 216 // cross-site but does not result in a SiteInstance swap because its
217 // renderer-initiated. 217 // renderer-initiated.
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
251 EXPECT_TRUE( 251 EXPECT_TRUE(
252 DidRenderFrameHostRequestCommit(GetSpeculativeRenderFrameHost(node))); 252 DidRenderFrameHostRequestCommit(GetSpeculativeRenderFrameHost(node)));
253 } else { 253 } else {
254 EXPECT_TRUE(DidRenderFrameHostRequestCommit(main_test_rfh())); 254 EXPECT_TRUE(DidRenderFrameHostRequestCommit(main_test_rfh()));
255 } 255 }
256 EXPECT_TRUE(main_test_rfh()->is_loading()); 256 EXPECT_TRUE(main_test_rfh()->is_loading());
257 EXPECT_FALSE(node->navigation_request()); 257 EXPECT_FALSE(node->navigation_request());
258 258
259 // Commit the navigation. 259 // Commit the navigation.
260 main_test_rfh()->SendNavigate(1, 0, true, kUrl2); 260 main_test_rfh()->SendNavigate(1, 0, true, kUrl2);
261 EXPECT_EQ(RenderFrameHostImpl::STATE_DEFAULT, main_test_rfh()->rfh_state()); 261 EXPECT_TRUE(main_test_rfh()->is_active());
262 EXPECT_EQ(kUrl2, contents()->GetLastCommittedURL()); 262 EXPECT_EQ(kUrl2, contents()->GetLastCommittedURL());
263 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node)); 263 EXPECT_FALSE(GetSpeculativeRenderFrameHost(node));
264 EXPECT_FALSE(node->render_manager()->pending_frame_host()); 264 EXPECT_FALSE(node->render_manager()->pending_frame_host());
265 265
266 // The SiteInstance did not change. 266 // The SiteInstance did not change.
267 EXPECT_EQ(site_instance_id_1, main_test_rfh()->GetSiteInstance()->GetId()); 267 EXPECT_EQ(site_instance_id_1, main_test_rfh()->GetSiteInstance()->GetId());
268 } 268 }
269 269
270 // PlzNavigate: Test that a beforeUnload denial cancels the navigation. 270 // PlzNavigate: Test that a beforeUnload denial cancels the navigation.
271 TEST_F(NavigatorTestWithBrowserSideNavigation, 271 TEST_F(NavigatorTestWithBrowserSideNavigation,
(...skipping 888 matching lines...) Expand 10 before | Expand all | Expand 10 after
1160 main_test_rfh()->PrepareForCommit(); 1160 main_test_rfh()->PrepareForCommit();
1161 1161
1162 // Claim that the navigation was within same page. 1162 // Claim that the navigation was within same page.
1163 int bad_msg_count = process()->bad_msg_count(); 1163 int bad_msg_count = process()->bad_msg_count();
1164 GetSpeculativeRenderFrameHost(node)->SendNavigateWithModificationCallback( 1164 GetSpeculativeRenderFrameHost(node)->SendNavigateWithModificationCallback(
1165 0, entry_id, true, kUrl2, base::Bind(SetWithinPage, kUrl1)); 1165 0, entry_id, true, kUrl2, base::Bind(SetWithinPage, kUrl1));
1166 EXPECT_EQ(process()->bad_msg_count(), bad_msg_count + 1); 1166 EXPECT_EQ(process()->bad_msg_count(), bad_msg_count + 1);
1167 } 1167 }
1168 1168
1169 } // namespace content 1169 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698