Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849343003: mac: Remove IsOSSnowLeopard(). (Closed)

Created:
4 years, 8 months ago by Nico
Modified:
4 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, felt, chromoting-reviews_chromium.org, tfarina, jam, gavinp+memory_chromium.org, rickyz+watch_chromium.org, darin-cc_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, kinuko+watch
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mac: Remove IsOSSnowLeopard(). BUG=579255 TBR=erikchen, thestig Committed: https://crrev.com/708618eab03e7fbac19035ac78c1c2a4c0e72495 Cr-Commit-Position: refs/heads/master@{#384946}

Patch Set 1 #

Patch Set 2 : err #

Total comments: 7

Patch Set 3 : . #

Patch Set 4 : one more #

Patch Set 5 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -454 lines) Patch
M base/mac/mac_util.h View 1 2 3 4 2 chunks +0 lines, -4 lines 0 comments Download
M base/mac/mac_util.mm View 1 2 3 chunks +2 lines, -13 lines 0 comments Download
M base/mac/mac_util_unittest.mm View 1 5 chunks +1 line, -23 lines 0 comments Download
M base/memory/shared_memory_mac_unittest.cc View 9 chunks +0 lines, -36 lines 0 comments Download
M base/process/memory_mac.mm View 1 chunk +3 lines, -10 lines 0 comments Download
M chrome/browser/apps/app_window_interactive_uitest.cc View 5 chunks +0 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/activity_log_private/activity_log_private_apitest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_test.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/mac/bluetooth_utility.mm View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm View 2 chunks +6 lines, -54 lines 0 comments Download
M chrome/browser/ui/cocoa/apps/native_app_window_cocoa_browsertest.mm View 5 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_browsertest.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_private.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller_unittest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/presentation_mode_controller.mm View 1 chunk +0 lines, -15 lines 0 comments Download
M chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/renderer_context_menu/render_view_context_menu_mac_browsertest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm View 1 chunk +0 lines, -8 lines 0 comments Download
M content/common/common.sb View 2 chunks +0 lines, -7 lines 0 comments Download
M content/common/sandbox_mac.mm View 1 chunk +0 lines, -10 lines 0 comments Download
M ipc/attachment_broker_mac_unittest.cc View 14 chunks +0 lines, -56 lines 0 comments Download
M ipc/attachment_broker_privileged_mac_unittest.cc View 3 chunks +0 lines, -12 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 1 chunk +1 line, -9 lines 0 comments Download
M remoting/host/desktop_resizer_mac.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M sandbox/mac/bootstrap_sandbox_unittest.mm View 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/VersionUtilMac.h View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/mac/VersionUtilMac.mm View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/scroll/Scrollbar.cpp View 2 chunks +0 lines, -20 lines 0 comments Download
M third_party/apple_apsl/CFBase.h View 1 chunk +0 lines, -20 lines 0 comments Download
M ui/base/test/scoped_fake_nswindow_fullscreen.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/base/test/scoped_fake_nswindow_fullscreen_unittest.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_interactive_uitest.mm View 3 chunks +0 lines, -10 lines 0 comments Download
M ui/views/cocoa/bridged_native_widget_unittest.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/views/cocoa/views_scrollbar_bridge.mm View 2 chunks +1 line, -6 lines 0 comments Download
M ui/views/widget/native_widget_mac_interactive_uitest.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 3 chunks +3 lines, -23 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
Nico
ellyjones: WebKit rsesek: rest I think the bots will be green if I run them ...
4 years, 8 months ago (2016-04-01 21:12:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849343003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849343003/20001
4 years, 8 months ago (2016-04-01 21:20:22 UTC) #4
Robert Sesek
https://codereview.chromium.org/1849343003/diff/20001/base/mac/mac_util.mm File base/mac/mac_util.mm (right): https://codereview.chromium.org/1849343003/diff/20001/base/mac/mac_util.mm#newcode388 base/mac/mac_util.mm:388: // OS X can launch items for the resume ...
4 years, 8 months ago (2016-04-01 21:24:42 UTC) #5
Nico
thanks! https://codereview.chromium.org/1849343003/diff/20001/base/mac/mac_util.mm File base/mac/mac_util.mm (right): https://codereview.chromium.org/1849343003/diff/20001/base/mac/mac_util.mm#newcode388 base/mac/mac_util.mm:388: // OS X can launch items for the ...
4 years, 8 months ago (2016-04-01 21:29:10 UTC) #6
Robert Sesek
LGTM https://codereview.chromium.org/1849343003/diff/20001/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right): https://codereview.chromium.org/1849343003/diff/20001/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm#newcode401 chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm:401: is_fullscreen_ = fullscreen; On 2016/04/01 21:29:10, Nico wrote: ...
4 years, 8 months ago (2016-04-01 21:30:04 UTC) #7
Elly Fong-Jones
On 2016/04/01 21:30:04, Robert Sesek wrote: > LGTM > > https://codereview.chromium.org/1849343003/diff/20001/chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm > File chrome/browser/ui/cocoa/apps/native_app_window_cocoa.mm (right): ...
4 years, 8 months ago (2016-04-04 15:42:01 UTC) #8
Nico
tbr erikchen for ipc, thestig for printing
4 years, 8 months ago (2016-04-04 15:45:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849343003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849343003/80001
4 years, 8 months ago (2016-04-04 15:45:33 UTC) #14
erikchen
ipc/ lgtm
4 years, 8 months ago (2016-04-04 15:59:44 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-04 17:54:52 UTC) #17
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/708618eab03e7fbac19035ac78c1c2a4c0e72495 Cr-Commit-Position: refs/heads/master@{#384946}
4 years, 8 months ago (2016-04-04 17:55:53 UTC) #19
Lei Zhang
4 years, 8 months ago (2016-04-04 18:56:49 UTC) #20
Message was sent while issue was closed. 
printing/ lgtm, but I think |thread_pdf_docs_owned_| is always false now. I will
follow up.

Powered by Google App Engine
This is Rietveld 408576698