Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 184933002: Move to using focusedElement instead of focusedNode (Closed)

Created:
6 years, 9 months ago by maheshkk
Modified:
6 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move to using focusedElement instead of focusedNode Move to focusedElement() as focusedNode is deprecated and will be removed soon.. BUG=258763 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255362

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/accessibility/renderer_accessibility_focus_only.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 27 (0 generated)
maheshkk
Please review. Last instance of focusedNode() usage left. focusedNode APIs will be removed once this ...
6 years, 9 months ago (2014-02-28 20:43:45 UTC) #1
maheshkk
PTAL
6 years, 9 months ago (2014-03-03 18:13:05 UTC) #2
jam
lgtm
6 years, 9 months ago (2014-03-03 20:33:04 UTC) #3
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-03 21:14:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184933002/1
6 years, 9 months ago (2014-03-03 21:17:42 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-03 22:58:12 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=273450
6 years, 9 months ago (2014-03-03 22:58:12 UTC) #7
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-03 23:00:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184933002/1
6 years, 9 months ago (2014-03-03 23:03:17 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 00:10:24 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=273528
6 years, 9 months ago (2014-03-04 00:10:24 UTC) #11
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-04 16:17:52 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184933002/1
6 years, 9 months ago (2014-03-04 16:18:40 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-04 18:59:28 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=274080
6 years, 9 months ago (2014-03-04 18:59:29 UTC) #15
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-05 05:15:31 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184933002/1
6 years, 9 months ago (2014-03-05 05:19:24 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 09:13:15 UTC) #18
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275094
6 years, 9 months ago (2014-03-05 09:13:16 UTC) #19
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-05 20:58:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184933002/1
6 years, 9 months ago (2014-03-05 20:59:31 UTC) #21
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-05 22:40:33 UTC) #22
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=275680
6 years, 9 months ago (2014-03-05 22:40:33 UTC) #23
maheshkk
The CQ bit was checked by mahesh.kk@samsung.com
6 years, 9 months ago (2014-03-06 16:04:23 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/184933002/1
6 years, 9 months ago (2014-03-06 16:05:08 UTC) #25
commit-bot: I haz the power
Change committed as 255362
6 years, 9 months ago (2014-03-06 16:06:19 UTC) #26
maheshkk
6 years, 9 months ago (2014-03-06 16:20:10 UTC) #27
Message was sent while issue was closed. 
I added NoTry=true because this change is just a rename of
WebDocument::focusedNode to WebDocument::focusedElement. This could not cause
win_rel failures and must be test flakiness.

Powered by Google App Engine
This is Rietveld 408576698