Pull gpu CmdBuf service/client shared GpuMemoryBuffer code to common

Pull gpu CmdBuf service/client shared GpuMemoryBuffer code to common

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cfa7caed85224a5a08d48961e3cbee35d4effbd3
Cr-Commit-Position: refs/heads/master@{#385554}

[Peng, 2016-04-01 18:54:11]

Description was changed from

==========
Pull gpu CmdBuf service/client shared GpuMemoryBuffer code to common

BUG=586380
==========

to

==========
Pull gpu CmdBuf service/client shared GpuMemoryBuffer code to common

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Peng, 2016-04-04 19:10:47]

penghuang@chromium.org changed reviewers:
+ piman@chromium.org

[Peng, 2016-04-04 19:10:48]

Hi piman, PTAL. Thanks.

[piman, 2016-04-04 20:49:10]

https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
File gpu/command_buffer/common/BUILD.gn (right):

https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
gpu/command_buffer/common/BUILD.gn:67: # compile on nacl.
Can you replace the include by <GLES2/gl2.h> and use
//third_party/khronos:khronos_headers as a dependency?

That should compile correctly in NaCl, it's needed by other bits.

[Peng, 2016-04-04 20:54:35]

https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
File gpu/command_buffer/common/BUILD.gn (right):

https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
gpu/command_buffer/common/BUILD.gn:67: # compile on nacl.
On 2016/04/04 20:49:10, piman wrote:
> Can you replace the include by <GLES2/gl2.h> and use
> //third_party/khronos:khronos_headers as a dependency?
> 
> That should compile correctly in NaCl, it's needed by other bits.

gpu_memory_buffer_support.cc needs some chromium specified GL defines which are
defined in ui/gl/gl_bindings.h, so have to depends on it.

For example: GL_RGB_YCBCR_422_CHROMIUM.

[piman, 2016-04-05 19:36:23]

On 2016/04/04 20:54:35, Peng wrote:
>
https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
> File gpu/command_buffer/common/BUILD.gn (right):
> 
>
https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
> gpu/command_buffer/common/BUILD.gn:67: # compile on nacl.
> On 2016/04/04 20:49:10, piman wrote:
> > Can you replace the include by <GLES2/gl2.h> and use
> > //third_party/khronos:khronos_headers as a dependency?
> > 
> > That should compile correctly in NaCl, it's needed by other bits.
> 
> gpu_memory_buffer_support.cc needs some chromium specified GL defines which
are
> defined in ui/gl/gl_bindings.h, so have to depends on it.
> 
> For example: GL_RGB_YCBCR_422_CHROMIUM.

GL_RGB_YCBCR_422_CHROMIUM is available from khronos_header. Try adding
<GLES2/gl2extchromium.h> which defines chromium extensions.
GLES2Implementation (client-side) certainly references it. Client/common code
should not use gl_bindings.h which is exclusively service-side.

[Peng, 2016-04-06 14:28:54]

https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
File gpu/command_buffer/common/BUILD.gn (right):

https://codereview.chromium.org/1849313002/diff/140001/gpu/command_buffer/com...
gpu/command_buffer/common/BUILD.gn:67: # compile on nacl.
On 2016/04/04 20:54:35, Peng wrote:
> On 2016/04/04 20:49:10, piman wrote:
> > Can you replace the include by <GLES2/gl2.h> and use
> > //third_party/khronos:khronos_headers as a dependency?
> > 
> > That should compile correctly in NaCl, it's needed by other bits.
> 
> gpu_memory_buffer_support.cc needs some chromium specified GL defines which
are
> defined in ui/gl/gl_bindings.h, so have to depends on it.
> 
> For example: GL_RGB_YCBCR_422_CHROMIUM.

Done.

[piman, 2016-04-06 17:46:37]

LGTM, thanks!

[Peng, 2016-04-06 17:49:34]

On 2016/04/06 17:46:37, piman wrote:
> LGTM, thanks!

:) thank you for reviewing.

[Peng, 2016-04-06 17:49:41]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2016-04-06 17:50:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849313002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849313002/180001

[Peng, 2016-04-06 17:57:22]

penghuang@chromium.org changed reviewers:
+ ben@chromium.org

[Peng, 2016-04-06 17:57:23]

+ben for components/mus/* & mojo/*

Hi Ben, PTAL. Thanks.

[commit-bot: I haz the power, 2016-04-06 18:02:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:02:35]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Fady Samuel, 2016-04-06 18:04:03]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-04-06 18:04:03]

lgtm

[Peng, 2016-04-06 18:04:50]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:05:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849313002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849313002/180001

[commit-bot: I haz the power, 2016-04-06 18:16:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 18:16:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2016-04-06 20:59:36]

lgtm

[Peng, 2016-04-06 21:00:05]

The CQ bit was checked by penghuang@chromium.org

[commit-bot: I haz the power, 2016-04-06 21:00:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849313002/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849313002/180001

[commit-bot: I haz the power, 2016-04-06 21:12:03]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2016-04-06 21:14:32]

Description was changed from

==========
Pull gpu CmdBuf service/client shared GpuMemoryBuffer code to common

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Pull gpu CmdBuf service/client shared GpuMemoryBuffer code to common

BUG=586380
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/cfa7caed85224a5a08d48961e3cbee35d4effbd3
Cr-Commit-Position: refs/heads/master@{#385554}
==========

[commit-bot: I haz the power, 2016-04-06 21:14:34]

Patchset 10 (id:??) landed as
https://crrev.com/cfa7caed85224a5a08d48961e3cbee35d4effbd3
Cr-Commit-Position: refs/heads/master@{#385554}

[jonnialva90, 2016-05-25 13:55:45]

jonnialva90@gmail.com changed reviewers:
+ jonnialva90@gmail.com