AutoRolls include Chromium bug links

go/util/util.go

 package util
 
 import (
         "crypto/md5"
         "crypto/rand"
         "crypto/sha256"
         "fmt"
         "io"
         "math"
         mathrand "math/rand"
@@ skipping 10 matching lines @@
 )
 
 const (
         _          = iota // ignore first value by assigning to blank identifier
         KB float64 = 1 << (10 * iota)
         MB
         GB
         TB
         PB
 
+        PROJECT_CHROMIUM    = "chromium"
+        BUG_DEFAULT_PROJECT = PROJECT_CHROMIUM
+        BUGS_PATTERN        = "(?m)^BUG=(.+)$"
+
         SECONDS_TO_MILLIS = int64(time.Second / time.Millisecond)
         MILLIS_TO_NANOS   = int64(time.Millisecond / time.Nanosecond)
 
         // time.RFC3339Nano only uses as many sub-second digits are required to
         // represent the time, which makes it unsuitable for sorting. This
         // format ensures that all 9 nanosecond digits are used, padding with
         // zeroes if necessary.
         RFC3339NanoZeroPad = "2006-01-02T15:04:05.000000000Z07:00"
 )
 
 var (
+        BUGS_REGEX = regexp.MustCompile(BUGS_PATTERN)
+
         // randomNameAdj is a list of adjectives for building random names.
         randomNameAdj = []string{
                 "autumn", "hidden", "bitter", "misty", "silent", "empty", "dry", "dark",
                 "summer", "icy", "delicate", "quiet", "white", "cool", "spring", "winter",
                 "patient", "twilight", "dawn", "crimson", "wispy", "weathered", "blue",
                 "billowing", "broken", "cold", "damp", "falling", "frosty", "green",
                 "long", "late", "lingering", "bold", "little", "morning", "muddy", "old",
                 "red", "rough", "still", "small", "sparkling", "throbbing", "shy",
                 "wandering", "withered", "wild", "black", "young", "holy", "solitary",
                 "fragrant", "aged", "snowy", "proud", "floral", "restless", "divine",
@@ skipping 545 matching lines @@
         if chunkSize < 1 {
                 return fmt.Errorf("Chunk size may not be less than 1.")
         }
         for c, r := s[:MinInt(chunkSize, len(s))], s[MinInt(chunkSize, len(s)):]; len(c) > 0; c, r = r[:MinInt(chunkSize, len(r))], r[MinInt(chunkSize, len(r)):] {
                 if err := fn(c); err != nil {
                         return err
                 }
         }
         return nil
 }
+
+// BugsFromCommitMsg parses BUG= tags from a commit message and returns them.
+func BugsFromCommitMsg(msg string) map[string][]string {
+        rv := map[string][]string{}
+        m := BUGS_REGEX.FindStringSubmatch(msg)
+        if len(m) > 1 {
+                bugs := strings.Split(m[1], ",")
+                for _, b := range bugs {
+                        b = strings.Trim(b, " ")
+                        split := strings.SplitN(strings.Trim(b, " "), ":", 2)
+                        project := BUG_DEFAULT_PROJECT
+                        bug := split[0]
+                        if len(split) > 1 {
+                                project = split[0]
+                                bug = split[1]
+                        }
+                        if rv[project] == nil {
+                                rv[project] = []string{}
+                        }
+                        rv[project] = append(rv[project], bug)
+                }
+        }
+        glog.Errorf("%v", rv)
+        return rv

[rmistry, 2016/04/04 12:45:09]

Why return a dictionary of projects to bugs? It would be simpler and still
correct to just parse out all strings delimited by ',' and return an array of
bugs which might contain contents like ["123", "chromium:123", "skia:123"]. You
can then blindly specify them in --bug.
This way you do not care about needing to make assumptions about what the
default project is, all this code will do is send straight through whatever is
specified as BUG= in the individual CLs.

[borenet, 2016/04/04 15:50:07]

The autoroller only wants to specify chromium bugs.  Others are not relevant to
DEPS rolls.  The caller could scan through and only take the "chromium:123" or
"123" bugs, but it makes more sense to me to do it here.  Plus, I'm doubtful
that the default project will ever change.

+}