Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 1849233003: S390: [ic] Use the CallFunction builtin to invoke accessors. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [ic] Use the CallFunction builtin to invoke accessors. port 6df9a22c3f8d6640e867ca659c95e22289b00b40 Original Commit Message: The HandlerCompiler did not properly handle the weird edge case when a sloppy mode function was installed as an accessor on one of the value wrapper prototypes and then accessed via a load from a primitive value. In this case we just passed the primitive value untouched instead of properly wrapping it first. The CallFunction builtin properly deals with all the funny edge cases, so we use it instead of duplicating almost all of the logic here (the performance difference is neglible). R=verwaest@chromium.org, bmeurer@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com BUG=chromium:599073, v8:4413 LOG=n Committed: https://crrev.com/6c38fde94e3f0996854be741f369a16aa65e871a Cr-Commit-Position: refs/heads/master@{#35217}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M src/ic/s390/handler-compiler-s390.cc View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-01 18:59:33 UTC) #1
MTBrandyberry
lgtm
4 years, 8 months ago (2016-04-01 19:06:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849233003/1
4 years, 8 months ago (2016-04-01 19:10:56 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 19:31:16 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 19:33:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6c38fde94e3f0996854be741f369a16aa65e871a
Cr-Commit-Position: refs/heads/master@{#35217}

Powered by Google App Engine
This is Rietveld 408576698