third_party/WebKit/Source/core/loader/FrameFetchContext.h - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.h

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests modified as per feedback and code comments added Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp ('K') | « third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp ('k') | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | third_party/WebKit/Source/core/testing/InternalSettings.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/loader/FrameFetchContext.h

diff --git a/third_party/WebKit/Source/core/loader/FrameFetchContext.h b/third_party/WebKit/Source/core/loader/FrameFetchContext.h

index c652b30862cea651327bc5bbe11bf0b37ddc5bc8..28a2c0346b58389834d96223f575de46d181c9b6 100644

--- a/third_party/WebKit/Source/core/loader/FrameFetchContext.h

+++ b/third_party/WebKit/Source/core/loader/FrameFetchContext.h

@@ -70,7 +70,7 @@ public:

void addAdditionalRequestHeaders(ResourceRequest&, FetchResourceType) override;

void setFirstPartyForCookies(ResourceRequest&) override;

CachePolicy getCachePolicy() const override;

- ResourceRequestCachePolicy resourceRequestCachePolicy(const ResourceRequest&, Resource::Type) const override;

+ ResourceRequestCachePolicy resourceRequestCachePolicy(const ResourceRequest&, Resource::Type, FetchRequest::DeferOption = FetchRequest::NoDefer) const override;

jkarlin 2016/04/06 14:55:31 This is a virtual function so it shouldn't use def

shivanisha 2016/04/06 20:40:10 Ah, I missed that even overrides of virtual functi

void dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoadPriority, int intraPriorityValue) override;

void dispatchWillSendRequest(unsigned long identifier, ResourceRequest&, const ResourceResponse& redirectResponse, const FetchInitiatorInfo& = FetchInitiatorInfo()) override;

void dispatchDidLoadResourceFromMemoryCache(const Resource*, WebURLRequest::FrameType, WebURLRequest::RequestContext) override;