third_party/WebKit/Source/core/fetch/FetchContext.h - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/FetchContext.h

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Tests modified as per feedback and code comments added Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block3-expected.txt ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/resources/js-loaded1.js ('k') | third_party/WebKit/Source/core/fetch/FetchContext.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/FetchContext.h

diff --git a/third_party/WebKit/Source/core/fetch/FetchContext.h b/third_party/WebKit/Source/core/fetch/FetchContext.h

index d4259504e16b97fc3902001d5a3236f04b1a3749..5d8d182c3714332ff083397de3033c6477b119f7 100644

--- a/third_party/WebKit/Source/core/fetch/FetchContext.h

+++ b/third_party/WebKit/Source/core/fetch/FetchContext.h

@@ -72,7 +72,7 @@ public:

virtual void addAdditionalRequestHeaders(ResourceRequest&, FetchResourceType);

virtual void setFirstPartyForCookies(ResourceRequest&);

virtual CachePolicy getCachePolicy() const;

- virtual ResourceRequestCachePolicy resourceRequestCachePolicy(const ResourceRequest&, Resource::Type) const;

+ virtual ResourceRequestCachePolicy resourceRequestCachePolicy(const ResourceRequest&, Resource::Type, FetchRequest::DeferOption) const;

virtual void dispatchDidChangeResourcePriority(unsigned long identifier, ResourceLoadPriority, int intraPriorityValue);

virtual void dispatchWillSendRequest(unsigned long identifier, ResourceRequest&, const ResourceResponse& redirectResponse, const FetchInitiatorInfo& = FetchInitiatorInfo());