third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2.html - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2.html

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added layout tests and review comments incorporation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block1.html ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block1-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block2-expected.txt » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test('Makes sure synchronous third-party scripts in document.w rite are blocked');

	6 var src = 'http://localhost:8000/loading/resources/js-loaded.js';

	7 var jsLoaded = false;

	8 if (window.internals){

	9 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(true) ;

	10 internals.setNetworkStateNotifierTestOnly(true);

	11 internals.setNetworkConnectionInfo('cellular2g', 2.0);

	12 }

	13 document.write('<scr' + 'ipt src="' + src + '" async></scr' + 'ipt>');

	14 </script>

	15 <script>

	16 window.addEventListener("load", t.step_func(function() {

	17 assert_true(jsLoaded, "third party but asynchronous doc.written scripts are not blocked");

	18 t.done();

	19 }));

	20 window.addEventListener('beforeunload', function() {

	21 internals.setNetworkStateNotifierTestOnly(false);

	22 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(false );

	23 }, false);

	24 </script>

OLD	NEW