third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block1.html - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block1.html

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added layout tests and review comments incorporation Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html ('K') | « third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block-expected.txt ('k') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block1-expected.txt » ('j') | third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test('Makes sure synchronous third-party scripts in document.w rite are blocked');

	6 var src = 'http://localhost:8000/loading/resources/js-loaded.js';

	7 var jsLoaded = false;

	8 if (window.internals){

	9 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(true) ;

	10 internals.setNetworkStateNotifierTestOnly(true);

	11 internals.setNetworkConnectionInfo('cellular2g', 2.0);

	12 }

	13 document.write('<scr' + 'ipt src="' + src + '"></scr' + 'ipt>');

	14 </script>

	15 <script>

	16 window.addEventListener("load", t.step_func(function() {

	17 assert_false(jsLoaded, "third party and sync doc.written scripts are blo cked");
	Bryan McQuade 2016/04/05 12:46:11 For this and other tests, let's also assert that t For this and other tests, let's also assert that the DOM APIs report the expected load success/failure status. Something like: var loadSuccess=undefined; document.write('<script src=... onload="loadSuccess=true" onerror="loadSuccess=false"></scr'+'ipt>'); assert_true(typeof loadSuccess === 'boolean', 'loadSuccess script load status not set after load'); assert_false(loadSuccess, 'third party and sync doc.written scripts are blocked'); You may want to roll this all up into a helper js function that takes a script URL and an expected success / failure result, e.g. function assertExpectedScriptLoad(scriptUrl, expectedResult) { var jsLoaded = false; var loadSuccess = undefined; document.write('<script src="' + scriptUrl + '" onload="loadSuccess=true" onerror="loadSuccess=false"></scr'+'ipt>'); assert_true(typeof loadSuccess === 'boolean', 'loadSuccess script load status not set after load'); assert_true(loadSuccess === expectedResult, ...); if (expectedResult) { assert_true(jsLoaded, ...); } } you should be able to use this to validate behavior for all except the async case, which will require an async test. shivanisha 2016/04/05 20:37:14 It seems asserts provided by testharness.js only w It seems asserts provided by testharness.js only work well within the test function so I am not able to use this modular function approach. Also, I observed this works: <script> var jsLoaded = false; document.write (script) </script> And then in another script tag, asserting the values of jsLoaded and loadSuccess in the test function work as expected but if I put the test function in the above script tag, they do not reflect the expected values of the variables after script load. Not sure why this happens but for the time being keeping separate script tags.
	18 t.done();

	19 }));

	20 window.addEventListener('beforeunload', function() {

	21 internals.setNetworkStateNotifierTestOnly(false);

	22 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(false );

	23 }, false);

	24

	25 </script>

OLD	NEW