third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html - Issue 1849223002: Blocking synchronous and third party doc.written scripts

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script.html

Issue 1849223002: Blocking synchronous and third party doc.written scripts (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Applied patch on latest from origin/master, review comments Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-async-third-party-script-expected.txt » ('j') | third_party/WebKit/LayoutTests/http/tests/loading/doc-write-sync-third-party-script-block.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../resources/testharness.js"></script>

	3 <script src="../resources/testharnessreport.js"></script>

	4 <script>

	5 var t = async_test('Cross origin but asynchronous doc.written scripts are no t blocked');

	6 var src = 'http://localhost:8000/loading/resources/js-loaded.js?2';

	7 var jsLoaded = false;

	8 var loadSuccess = false;

	9 if (window.internals){
	jkarlin 2016/04/08 17:17:59 space between ) and { space between ) and { shivanisha 2016/04/08 18:41:10 Added Show quoted text On 2016/04/08 at 17:17:59, jkarlin wrote: > space between ) and { Added
	10 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(true) ;

	11 internals.setNetworkStateNotifierTestOnly(true);

	12 internals.setNetworkConnectionInfo('cellular2g', 2.0);

	13 }

	14 document.write('<scr' + 'ipt src="' + src + '" onload="loadSuccess=true" as ync></scr' + 'ipt>');

	15 </script>

	16 <script>

	17 window.addEventListener("load", t.step_func(function() {

	18 assert_true(loadSuccess, "Script loaded successfully");

	19 assert_true(jsLoaded, "Cross origin but asynchronous doc.written scripts are not blocked");

	20 t.done();

	21 }));

	22 window.addEventListener('beforeunload', function() {

	23 internals.setNetworkStateNotifierTestOnly(false);

	24 internals.settings.setDisallowFetchForDocWrittenScriptsInMainFrame(false );

	25 }, false);

	26 </script>

OLD	NEW