Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(447)

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp

Issue 1849213002: Remove SK_SUPPORT_LEGACY_XFERMODE_PTR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Adopt the pointer but don't ref it Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
diff --git a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
index 150b48bb0ca0790c687361e2d00989a9dc20a50b..920255940a516650451f71845fec6f348c957045 100644
--- a/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
+++ b/third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
@@ -217,10 +217,10 @@ PassRefPtr<SkImageFilter> SkiaImageFilterBuilder::buildBoxReflectFilter(Reflecti
RefPtr<SkImageFilter> flipImageFilter = adoptRef(SkImageFilter::CreateMatrixFilter(
flipMatrix, kNone_SkFilterQuality, maskedInput.get()));
- RefPtr<SkImageFilter> combineImageFilter = adoptRef(SkXfermodeImageFilter::Create(
- nullptr, flipImageFilter.get(), input));
+ sk_sp<SkImageFilter> combineImageFilter = SkXfermodeImageFilter::Make(
+ nullptr, flipImageFilter.get(), input, nullptr);
- return combineImageFilter.release();
+ return fromSkSp(combineImageFilter);
f(malita) 2016/04/01 18:16:00 std::move or inline.
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698