third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp - Issue 1849213002: Remove SK_SUPPORT_LEGACY_XFERMODE_PTR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp

Issue 1849213002: Remove SK_SUPPORT_LEGACY_XFERMODE_PTR (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adopt the pointer but don't ref it Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp ('K') | « third_party/WebKit/Source/modules/canvas2d/BaseRenderingContext2D.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp » ('j') | third_party/WebKit/Source/platform/graphics/filters/FEBlend.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp b/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp

index e145c23f18124452ec36d4615212afae0658348f..69f6ef70c3328a59d98fb0a5b4630d545520932e 100644

--- a/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp

+++ b/third_party/WebKit/Source/platform/graphics/CrossfadeGeneratedImage.cpp

@@ -50,7 +50,7 @@ void CrossfadeGeneratedImage::drawCrossfade(SkCanvas* canvas, const SkPaint& pai

// to preserve pre-existing behavior while refactoring this code. This should be

// investigated further. crbug.com/472634

SkPaint layerPaint;

- layerPaint.setXfermode(paint.getXfermode());

+ layerPaint.setXfermode(sk_ref_sp(paint.getXfermode()));

SkAutoCanvasRestore ar(canvas, false);

canvas->saveLayer(nullptr, &layerPaint);