Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1849203002: Removed unused non-const accessors for stylesheet lists. (Closed)

Created:
4 years, 8 months ago by rune
Modified:
4 years, 8 months ago
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed unused non-const accessors for stylesheet lists. R=mstensho@opera.com Committed: https://crrev.com/578ef93592829f4926658d23995eac569154c5e7 Cr-Commit-Position: refs/heads/master@{#384578}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M third_party/WebKit/Source/core/dom/StyleSheetCollection.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
rune
ptal
4 years, 8 months ago (2016-04-01 12:31:30 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849203002/1
4 years, 8 months ago (2016-04-01 12:31:40 UTC) #3
mstensho (USE GERRIT)
lgtm if it compiles. :)
4 years, 8 months ago (2016-04-01 12:34:18 UTC) #4
tfarina
Why is this good in general? If someone comes later and need a non-const version, ...
4 years, 8 months ago (2016-04-01 13:20:44 UTC) #6
rune
On 2016/04/01 13:20:44, tfarina wrote: > Why is this good in general? Encapsulation, and making ...
4 years, 8 months ago (2016-04-01 13:45:10 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-01 14:08:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849203002/1
4 years, 8 months ago (2016-04-01 14:13:41 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-01 14:18:03 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 14:19:29 UTC) #14
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/578ef93592829f4926658d23995eac569154c5e7
Cr-Commit-Position: refs/heads/master@{#384578}

Powered by Google App Engine
This is Rietveld 408576698