gpu/command_buffer/service/texture_manager_unittest.cc - Issue 18492005: Add GL_EXT_multisampled_render_to_texture support to command buffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/command_buffer/service/texture_manager_unittest.cc

Issue 18492005: Add GL_EXT_multisampled_render_to_texture support to command buffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: some cleanup Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« gpu/command_buffer/service/gles2_cmd_decoder.cc ('K') | « gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h ('k') | ui/gl/generate_bindings.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/command_buffer/service/texture_manager_unittest.cc

diff --git a/gpu/command_buffer/service/texture_manager_unittest.cc b/gpu/command_buffer/service/texture_manager_unittest.cc

index f8a3f6b0bbb7a97de89472fde799c014be23daf5..402cc8d0eff7b1394e8794b36d9b483eef7393aa 100644

--- a/gpu/command_buffer/service/texture_manager_unittest.cc

+++ b/gpu/command_buffer/service/texture_manager_unittest.cc

@@ -2233,7 +2233,7 @@ TEST_F(SharedTextureTest, FBOCompletenessCheck) {

scoped_refptr<Framebuffer> framebuffer1 =

framebuffer_manager1.GetFramebuffer(10);

framebuffer1->AttachTexture(

- GL_COLOR_ATTACHMENT0, ref1.get(), GL_TEXTURE_2D, 0);

+ GL_COLOR_ATTACHMENT0, ref1.get(), GL_TEXTURE_2D, 0, 0);

EXPECT_FALSE(framebuffer_manager1.IsComplete(framebuffer1.get()));

EXPECT_NE(kCompleteValue, framebuffer1->IsPossiblyComplete());

@@ -2261,7 +2261,7 @@ TEST_F(SharedTextureTest, FBOCompletenessCheck) {

scoped_refptr<Framebuffer> framebuffer2 =

framebuffer_manager2.GetFramebuffer(20);

framebuffer2->AttachTexture(

- GL_COLOR_ATTACHMENT0, ref2.get(), GL_TEXTURE_2D, 0);

+ GL_COLOR_ATTACHMENT0, ref2.get(), GL_TEXTURE_2D, 0, 0);

EXPECT_FALSE(framebuffer_manager2.IsComplete(framebuffer2.get()));

EXPECT_EQ(kCompleteValue, framebuffer2->IsPossiblyComplete());

framebuffer_manager2.MarkAsComplete(framebuffer2.get());