Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(986)

Unified Diff: chrome/android/java/res/layout/new_tab_page_snippets_card.xml

Issue 1849173002: Add a snippet item decoration to recycler view for cards and make the card full bleed with a divide… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@always-show-snippets
Patch Set: Update outRect to empty Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_header.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/res/layout/new_tab_page_snippets_card.xml
diff --git a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
index 5189e5138af709640b76a4aa5e1f2a36d29c0e25..8464c146d051ac431c60bf5471bdeae05c805285 100644
--- a/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
+++ b/chrome/android/java/res/layout/new_tab_page_snippets_card.xml
@@ -9,18 +9,7 @@
android:layout_width="match_parent"
android:layout_height="wrap_content"
android:padding="16dp"
- android:background="@drawable/bg_find_toolbar_popup">
-
- <ImageView
- android:id="@+id/article_thumbnail"
- android:layout_width="@dimen/snippets_thumbnail_size"
- android:layout_height="@dimen/snippets_thumbnail_size"
- android:layout_alignParentTop="true"
- android:layout_alignParentEnd="true"
- android:layout_marginStart="16dp"
- android:scaleType="centerCrop"
- android:contentDescription="@null"
- android:src="@null"/>
+ android:background="@color/snippets_background_color">
<TextView
android:id="@+id/article_headline"
@@ -57,4 +46,15 @@
android:ellipsize="end"
android:textSize="14sp"
android:textColor="@color/snippets_publisher_name_color" />
+
+ <ImageView
+ android:id="@+id/article_thumbnail"
+ android:layout_width="@dimen/snippets_thumbnail_size"
+ android:layout_height="@dimen/snippets_thumbnail_size"
+ android:layout_alignParentTop="true"
+ android:layout_alignParentEnd="true"
+ android:layout_marginStart="16dp"
+ android:scaleType="centerCrop"
+ android:contentDescription="@null"
+ android:src="@null"/>
</RelativeLayout>
« no previous file with comments | « no previous file | chrome/android/java/res/layout/new_tab_page_snippets_header.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698