chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java - Issue 1849173002: Add a snippet item decoration to recycler view for cards and make the card full bleed with a divide…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 1849173002: Add a snippet item decoration to recycler view for cards and make the card full bleed with a divide… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@always-show-snippets

Patch Set: Changes from review Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/values/dimens.xml ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetItemDecoration.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

index c43625bee6ceef310c98a4c7dc07972b36a73952..c5208ddac739699a681b28c93dd82712d9cd5b14 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

@@ -44,6 +44,7 @@ import org.chromium.chrome.browser.ntp.MostVisitedItem.MostVisitedItemManager;

import org.chromium.chrome.browser.ntp.NewTabPage.OnSearchBoxScrollListener;

import org.chromium.chrome.browser.ntp.cards.NewTabPageAdapter;

import org.chromium.chrome.browser.ntp.cards.NewTabPageRecyclerView;

+import org.chromium.chrome.browser.ntp.snippets.SnippetItemDecoration;

import org.chromium.chrome.browser.ntp.snippets.SnippetsBridge.SnippetsObserver;

import org.chromium.chrome.browser.profiles.MostVisitedSites.MostVisitedURLsObserver;

import org.chromium.chrome.browser.profiles.MostVisitedSites.ThumbnailCallback;

@@ -385,6 +386,7 @@ public class NewTabPageView extends FrameLayout

}

});

initializeSearchBoxRecyclerViewScrollHandling();

+ mRecyclerView.addItemDecoration(new SnippetItemDecoration(getContext()));

} else {

initializeSearchBoxScrollHandling();

}