Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Issue 1849153004: Add Bing image search to provder definition (Closed)

Created:
4 years, 8 months ago by mike.schechter
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, vasilii+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Bing image search to provder definition BUG=599972 Committed: https://crrev.com/35941ff926b6fa8f8fc5b407a2c5f81a3b763ae8 Cr-Commit-Position: refs/heads/master@{#384718}

Patch Set 1 #

Patch Set 2 : Data version update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M components/search_engines/prepopulated_engines.json View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
mike.schechter
This is small update to provide image search support on the built in Bing search ...
4 years, 8 months ago (2016-04-01 20:32:16 UTC) #3
Peter Kasting
You need to rev the data version number atop the file. With that, LGTM.
4 years, 8 months ago (2016-04-01 20:33:24 UTC) #4
mike.schechter
On 2016/04/01 20:33:24, Peter Kasting wrote: > You need to rev the data version number ...
4 years, 8 months ago (2016-04-01 21:23:16 UTC) #5
mike.schechter
On 2016/04/01 21:23:16, mike.schechter wrote: > On 2016/04/01 20:33:24, Peter Kasting wrote: > > You ...
4 years, 8 months ago (2016-04-01 21:24:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849153004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849153004/20001
4 years, 8 months ago (2016-04-01 21:25:00 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-01 23:46:37 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-01 23:48:08 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/35941ff926b6fa8f8fc5b407a2c5f81a3b763ae8
Cr-Commit-Position: refs/heads/master@{#384718}

Powered by Google App Engine
This is Rietveld 408576698