Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Issue 1849143004: Re-add blockquotes in Windows build instructions. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-add blockquotes in Windows build instructions. Also fix the switchover date. BUG=none R=brucedawson@chromium.org Committed: https://crrev.com/25484606ef5586b9f6d1e463abbd9018727a54e5 Cr-Commit-Position: refs/heads/master@{#384941}

Patch Set 1 #

Total comments: 4

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -27 lines) Patch
M docs/windows_build_instructions.md View 1 1 chunk +27 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
dcheng
4 years, 8 months ago (2016-04-02 07:07:13 UTC) #1
brucedawson
https://codereview.chromium.org/1849143004/diff/1/docs/windows_build_instructions.md File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1849143004/diff/1/docs/windows_build_instructions.md#newcode24 docs/windows_build_instructions.md:24: > Install Visual Studio 2015 Update 1 or later ...
4 years, 8 months ago (2016-04-02 20:48:09 UTC) #2
dcheng
https://codereview.chromium.org/1849143004/diff/1/docs/windows_build_instructions.md File docs/windows_build_instructions.md (right): https://codereview.chromium.org/1849143004/diff/1/docs/windows_build_instructions.md#newcode24 docs/windows_build_instructions.md:24: > Install Visual Studio 2015 Update 1 or later ...
4 years, 8 months ago (2016-04-03 00:34:43 UTC) #3
brucedawson
lgtm
4 years, 8 months ago (2016-04-04 17:07:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849143004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849143004/20001
4 years, 8 months ago (2016-04-04 17:08:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-04 17:49:08 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 17:50:11 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/25484606ef5586b9f6d1e463abbd9018727a54e5
Cr-Commit-Position: refs/heads/master@{#384941}

Powered by Google App Engine
This is Rietveld 408576698