Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1849133003: Work around dart:html inconsistency (Closed)

Created:
4 years, 8 months ago by vsm
Modified:
4 years, 8 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Work around dart:html inconsistency We're hitting a runtime bug on requestAnimationFrame when we compile against the latest dart:html in the analyzer (45) but run against the DDC one (based on 39). Adding the new type name by hand as a workaround until we roll, but longer term we'll need to compile and run against the same sdk. R=alanknight@google.com, leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/f6f752cfced3eb0b0404a8714ff07732138aede8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -123 lines) Patch
M lib/runtime/dart/html.js View 2 chunks +2 lines, -0 lines 0 comments Download
M test/codegen_test.dart View 2 chunks +9 lines, -8 lines 0 comments Download
M tool/input_sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tool/sdk_expected_errors.txt View 2 chunks +115 lines, -115 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
vsm
4 years, 8 months ago (2016-04-01 03:33:00 UTC) #3
Leaf
lgtm
4 years, 8 months ago (2016-04-01 16:02:41 UTC) #5
Alan Knight
lgtm
4 years, 8 months ago (2016-04-01 16:06:35 UTC) #6
vsm
Committed patchset #1 (id:1) manually as f6f752cfced3eb0b0404a8714ff07732138aede8 (presubmit successful).
4 years, 8 months ago (2016-04-01 16:07:13 UTC) #8
Jennifer Messerly
4 years, 8 months ago (2016-04-04 16:31:49 UTC) #9
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698