Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1849133002: MD History: Change paper-menus to paper-listboxes (Closed)

Created:
4 years, 8 months ago by tsergeant
Modified:
4 years, 8 months ago
Reviewers:
calamity, Dan Beam
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, dbeam+watch-elements_chromium.org, Patrick Dubroy, michaelpg+watch-md-ui_chromium.org, dbeam+watch-history_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD History: Change paper-menus to paper-listboxes paper-listbox is slimmer, as it does not have support for submenus (which we do not use anyway). The change does not cause any visible changes. BUG=589362 Committed: https://crrev.com/a3cf4fe7e0cb4cd504423fa6445c054aadfeeef0 Cr-Commit-Position: refs/heads/master@{#385129}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/browser/resources/md_history/side_bar.html View 3 chunks +9 lines, -12 lines 1 comment Download
M ui/webui/resources/cr_elements/cr_shared_menu/cr_shared_menu.html View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tsergeant
https://codereview.chromium.org/1849133002/diff/1/chrome/browser/resources/md_history/side_bar.html File chrome/browser/resources/md_history/side_bar.html (left): https://codereview.chromium.org/1849133002/diff/1/chrome/browser/resources/md_history/side_bar.html#oldcode25 chrome/browser/resources/md_history/side_bar.html:25: background: none; calamity: What exactly did this fix? I ...
4 years, 8 months ago (2016-04-01 03:01:54 UTC) #2
tsergeant
dbeam@, PTAL!
4 years, 8 months ago (2016-04-04 01:42:17 UTC) #4
Dan Beam
lgtm
4 years, 8 months ago (2016-04-05 06:55:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1849133002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1849133002/1
4 years, 8 months ago (2016-04-05 07:03:27 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-05 08:06:57 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 08:09:09 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3cf4fe7e0cb4cd504423fa6445c054aadfeeef0
Cr-Commit-Position: refs/heads/master@{#385129}

Powered by Google App Engine
This is Rietveld 408576698