Chromium Code Reviews
DescriptionRevert of Fixing a Dr. memory failure in the remoting unit tests. (patchset #3 id:40001 of https://codereview.chromium.org/1844423002/ )
Reason for revert:
However, this was the data posted to the server:
revert_reason: This change has caused failures on TSAN, and also caused the DrMemory bot to timeout.
See https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/18731
and
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/9978
revert_cq: 1
revert_reason_textarea: This change has caused failures on TSAN, and also caused the DrMemory bot to timeout.
See https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20TSan%20Tests/builds/18731
and
https://build.chromium.org/p/chromium.memory.fyi/builders/Windows%20Unit%20%28DrMemory%20full%29%20%283%29/builds/9978
xsrf_token: 3f3abe97db5300c6623390914f94b515
Original issue's description:
> Fixing a Dr. memory failure in the remoting unit tests.
>
> The test I checked in yesterday had a race condition in it which was detected
> by the Dr. Memory bot (they run more slowly than the normal bots). On a
> normal bot, my runloop quits when the first (of ~11) message is written but
> the other messages are processed and added to the vector by the time it is
> checked. On the Dr. Memory bot, this condition was exposed and the size check
> failed. The fix is to ensure that we are processing each message as it is
> written/received and validating the size afterwards.
>
> BUG=599494
>
> Committed: https://crrev.com/d0c1837abcd55db74ad07220bcc13e4c7dfb7e82
> Cr-Commit-Position: refs/heads/master@{#384354}
TBR=sergeyu@chromium.org,joedow@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=599494
Committed: https://crrev.com/512b6ea08ab2eea17f2af00b0cf988ce1a4afd2d
Cr-Commit-Position: refs/heads/master@{#384486}
Patch Set 1 #
Messages
Total messages: 6 (2 generated)
|
|||||||||||||||||||