third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h - Issue 1849023003: Remove the MSAA WebSetting, which is not read or used.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

Issue 1849023003: Remove the MSAA WebSetting, which is not read or used. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rm-alphadepthetc

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/frame/Settings.cpp ('K') | « third_party/WebKit/Source/core/page/Page.cpp ('k') | third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

index e1c84d99c7efb4915a8c0ca3e5a75293d2fdb219..de74054fe45256e5de45630f1ad390af4514ce96 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h

@@ -142,7 +142,7 @@ private:

Member<WebGLFramebuffer> m_readFramebufferBinding;

};

-class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext, public Page::MultisamplingChangedObserver {

+class MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(WebGLRenderingContextBase);

public:

~WebGLRenderingContextBase() override;

@@ -610,9 +610,6 @@ protected:

bool m_synthesizedErrorsToConsole;

int m_numGLErrorsToConsoleAllowed;

- bool m_multisamplingAllowed;

- bool m_multisamplingObserverRegistered;

unsigned long m_onePlusMaxNonDefaultTextureUnit;

OwnPtr<Extensions3DUtil> m_extensionsUtil;

@@ -1061,8 +1058,6 @@ protected:

virtual void restoreCurrentFramebuffer();

void restoreCurrentTexture2D();

- void multisamplingChanged(bool) override;

void findNewMaxNonDefaultTextureUnit();

virtual void renderbufferStorageImpl(GLenum target, GLsizei samples, GLenum internalformat, GLsizei width, GLsizei height, const char* functionName);