Remove the MSAA WebSetting, which is not read or used.

Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

See crbug.com/599721 for lots of investigation about this.

R=kbr@chromium.org
BUG=599721, 584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/1599e8b2b3b67e470656d8104b8f020559c9da53
Cr-Commit-Position: refs/heads/master@{#385065}

[danakj, 2016-04-01 00:17:42]

Description was changed from

==========
Remove the MSAA WebSetting, which is not read or used.

R=kbr@chromium.org
BUG=599721,584497
==========

to

==========
Remove the MSAA WebSetting, which is not read or used.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-01 00:27:14]

Description was changed from

==========
Remove the MSAA WebSetting, which is not read or used.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that descision based
on the WebSetting at all.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-01 00:27:19]

Description was changed from

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that descision based
on the WebSetting at all.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[danakj, 2016-04-01 01:11:04]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-01 01:11:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849023003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849023003/1

[commit-bot: I haz the power, 2016-04-01 01:23:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-01 01:23:54]

Dry run: Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[danakj, 2016-04-02 00:21:34]

danakj@chromium.org changed reviewers:
+ piman@chromium.org, zmo@google.com

[danakj, 2016-04-02 00:22:19]

https://bugs.chromium.org/p/chromium/issues/detail?id=599721 has
discussion/investigation to verify that this setting is not needed, nor the
notification causing us to forceLoseContext.

[piman, 2016-04-02 00:47:40]

lgtm

https://codereview.chromium.org/1849023003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Settings.cpp (right):

https://codereview.chromium.org/1849023003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Settings.cpp:63: ,
m_textAutosizingWindowSizeOverride(320, 480)
:, is unlikely to work...

[danakj, 2016-04-02 00:57:05]

https://codereview.chromium.org/1849023003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/Settings.cpp (right):

https://codereview.chromium.org/1849023003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/Settings.cpp:63: ,
m_textAutosizingWindowSizeOverride(320, 480)
On 2016/04/02 00:47:40, piman wrote:
> :, is unlikely to work...

oops, rekt. preprocessor ftl

[danakj, 2016-04-02 02:05:01]

danakj@chromium.org changed reviewers:
+ chrishtr@chromium.org

[danakj, 2016-04-02 02:05:01]

+chrishtr for core/ and public/

[danakj, 2016-04-02 02:05:55]

danakj@chromium.org changed reviewers:
+ dcheng@chromium.org

[danakj, 2016-04-02 02:05:56]

+dcheng for ipc traits (removing a field)

[dcheng, 2016-04-02 02:53:24]

lgtm

[chrishtr, 2016-04-04 15:17:40]

lgtm

[danakj, 2016-04-04 20:40:59]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-04-04 20:41:45]

zmo or kbr PTAL at the webgl parts. :)

[commit-bot: I haz the power, 2016-04-04 20:41:47]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849023003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849023003/40001

[danakj, 2016-04-04 20:42:18]

Description was changed from

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

See crbug.com/599721 for lots of investigation about this.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-04 21:55:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-04 21:55:58]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[Ken Russell (switch to Gerrit), 2016-04-04 21:57:59]

Thanks for tracking down this behavior and sorry for the mess in this area. The
workaround used to work, but we never added a regression test for it which is
why it bit-rotted.

Hopefully it's not necessary any more on any supported Mac.

LGTM

[danakj, 2016-04-04 22:10:22]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-04 22:10:23]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org,
chrishtr@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/1849023003/#ps40001
(title: "msaasettings: rebase-and-compile")

[danakj, 2016-04-04 22:10:41]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-04-04 22:30:28]

Added a DECLARE_EAGER_FINALIZATION_OPERATOR_NEW() to WebGLRCBase which makes the
layout tests stop asserting on my machine.

https://codereview.chromium.org/1849023003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h (left):

https://codereview.chromium.org/1849023003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h:145: class
MODULES_EXPORT WebGLRenderingContextBase : public CanvasRenderingContext, public
Page::MultisamplingChangedObserver {
The WebGLRCBase used to subclass Page::MultisamplingChangedObserver, which
subclasses GarbageCollectedMixin.

It also does EAGERLY_FINALIZE() down on line 413.

When I remove the subclass of GarbageCollectedMixin (and the
USING_GARBAGE_COLLECTED_MIXIN), I end up hitting an assert in
~VerifyEagerFinalization():
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I'm trying to parse the comment, but it seems to say that operator new needs to
be "eagerly finalized" by using DECLARE_EAGER_FINALIZATION_OPERATOR_NEW().

[danakj, 2016-04-04 22:32:51]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-04-04 22:32:51]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
chrishtr@chromium.org, dcheng@chromium.org, piman@chromium.org
Link to the patchset: https://codereview.chromium.org/1849023003/#ps60001
(title: "msaasettings: declareeager")

[commit-bot: I haz the power, 2016-04-04 22:33:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1849023003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1849023003/60001

[commit-bot: I haz the power, 2016-04-05 00:40:58]

Description was changed from

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

See crbug.com/599721 for lots of investigation about this.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

See crbug.com/599721 for lots of investigation about this.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-04-05 00:41:00]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-05 00:42:34]

Description was changed from

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

See crbug.com/599721 for lots of investigation about this.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Remove the MSAA WebSetting, which is not read or used.

The WebSetting *does* appear to do one thing, which is to lose the
WebGL context when we want to stop using MSAA (based on driver bugs
and having > 1 displays on OSX). However.. we'll make a new context
and continue to use MSAA since we don't make that decision based
on the WebSetting at all.

See crbug.com/599721 for lots of investigation about this.

R=kbr@chromium.org
BUG=599721,584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/1599e8b2b3b67e470656d8104b8f020559c9da53
Cr-Commit-Position: refs/heads/master@{#385065}
==========

[commit-bot: I haz the power, 2016-04-05 00:42:36]

Patchset 4 (id:??) landed as
https://crrev.com/1599e8b2b3b67e470656d8104b8f020559c9da53
Cr-Commit-Position: refs/heads/master@{#385065}

[haraken, 2016-04-05 01:34:55]

Sorry about the weird macros...

I'm not fully sure why we need DECLARE_EAGER_FINALIZATION_OPERATOR_NEW(), but
I'm planning to replace it with a pre-finalizer (USING_PRE_FINALIZER) soon. Then
you don't need to be bothered by strange macros :)

[haraken, 2016-04-05 01:35:08]

LGTM