Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1571)

Unified Diff: content/renderer/render_view_impl.h

Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertfix
Patch Set: ordering Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_view_impl.h
diff --git a/content/renderer/render_view_impl.h b/content/renderer/render_view_impl.h
index e162bf4bfc90fbf127a282e211d8ce9b41a87438..28d66c564985bb1f72890b8352867d48af0b5914 100644
--- a/content/renderer/render_view_impl.h
+++ b/content/renderer/render_view_impl.h
@@ -665,7 +665,6 @@ class CONTENT_EXPORT RenderViewImpl
void OnSetWebUIProperty(const std::string& name, const std::string& value);
void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level);
void OnSetZoomLevelForView(bool uses_temporary_zoom_level, double level);
- void OnSuppressDialogsUntilSwapOut();
void OnThemeChanged();
void OnUpdateTargetURLAck();
void OnUpdateWebPreferences(const WebPreferences& prefs);
@@ -800,11 +799,6 @@ class CONTENT_EXPORT RenderViewImpl
// Used for popups.
bool opened_by_user_gesture_;
- // Whether we must stop creating nested message loops for modal dialogs until
- // OnSwapOut is called. This is necessary because modal dialogs have a
- // PageGroupLoadDeferrer on the stack that interferes with swapping out.
- bool suppress_dialogs_until_swap_out_;
-
// Timer used to delay the updating of nav state (see
// StartNavStateSyncTimerIfNecessary).
base::OneShotTimer nav_state_sync_timer_;

Powered by Google App Engine
This is Rietveld 408576698