Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertfix
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 636 matching lines...) Expand 10 before | Expand all | Expand 10 after
647 void OnSetActive(bool active); 647 void OnSetActive(bool active);
648 void OnSetBackgroundOpaque(bool opaque); 648 void OnSetBackgroundOpaque(bool opaque);
649 void OnExitFullscreen(); 649 void OnExitFullscreen();
650 void OnSetHistoryOffsetAndLength(int history_offset, int history_length); 650 void OnSetHistoryOffsetAndLength(int history_offset, int history_length);
651 void OnSetInitialFocus(bool reverse); 651 void OnSetInitialFocus(bool reverse);
652 void OnSetPageEncoding(const std::string& encoding_name); 652 void OnSetPageEncoding(const std::string& encoding_name);
653 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs); 653 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs);
654 void OnSetWebUIProperty(const std::string& name, const std::string& value); 654 void OnSetWebUIProperty(const std::string& name, const std::string& value);
655 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level); 655 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level);
656 void OnSetZoomLevelForView(bool uses_temporary_zoom_level, double level); 656 void OnSetZoomLevelForView(bool uses_temporary_zoom_level, double level);
657 void OnSuppressDialogsUntilSwapOut();
658 void OnThemeChanged(); 657 void OnThemeChanged();
659 void OnUpdateTargetURLAck(); 658 void OnUpdateTargetURLAck();
660 void OnUpdateWebPreferences(const WebPreferences& prefs); 659 void OnUpdateWebPreferences(const WebPreferences& prefs);
661 void OnSetPageScale(float page_scale_factor); 660 void OnSetPageScale(float page_scale_factor);
662 void OnZoom(PageZoom zoom); 661 void OnZoom(PageZoom zoom);
663 void OnForceRedraw(int request_id); 662 void OnForceRedraw(int request_id);
664 void OnSelectWordAroundCaret(); 663 void OnSelectWordAroundCaret();
665 #if defined(OS_ANDROID) 664 #if defined(OS_ANDROID)
666 void OnUndoScrollFocusedEditableNodeIntoRect(); 665 void OnUndoScrollFocusedEditableNodeIntoRect();
667 void OnUpdateTopControlsState(bool enable_hiding, 666 void OnUpdateTopControlsState(bool enable_hiding,
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
777 776
778 // Loading state ------------------------------------------------------------- 777 // Loading state -------------------------------------------------------------
779 778
780 // The gesture that initiated the current navigation. 779 // The gesture that initiated the current navigation.
781 // TODO(nasko): Move to RenderFrame, as this is per-frame state. 780 // TODO(nasko): Move to RenderFrame, as this is per-frame state.
782 NavigationGesture navigation_gesture_; 781 NavigationGesture navigation_gesture_;
783 782
784 // Used for popups. 783 // Used for popups.
785 bool opened_by_user_gesture_; 784 bool opened_by_user_gesture_;
786 785
787 // Whether we must stop creating nested message loops for modal dialogs until
788 // OnSwapOut is called. This is necessary because modal dialogs have a
789 // PageGroupLoadDeferrer on the stack that interferes with swapping out.
790 bool suppress_dialogs_until_swap_out_;
791
792 // Timer used to delay the updating of nav state (see 786 // Timer used to delay the updating of nav state (see
793 // StartNavStateSyncTimerIfNecessary). 787 // StartNavStateSyncTimerIfNecessary).
794 base::OneShotTimer nav_state_sync_timer_; 788 base::OneShotTimer nav_state_sync_timer_;
795 789
796 // Set of RenderFrame routing IDs for frames that having pending UpdateState 790 // Set of RenderFrame routing IDs for frames that having pending UpdateState
797 // messages to send when the next |nav_state_sync_timer_| fires. 791 // messages to send when the next |nav_state_sync_timer_| fires.
798 std::set<int> frames_with_pending_state_; 792 std::set<int> frames_with_pending_state_;
799 793
800 // Page IDs ------------------------------------------------------------------ 794 // Page IDs ------------------------------------------------------------------
801 // See documentation in RenderView. 795 // See documentation in RenderView.
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
982 // use the Observer interface to filter IPC messages and receive frame change 976 // use the Observer interface to filter IPC messages and receive frame change
983 // notifications. 977 // notifications.
984 // --------------------------------------------------------------------------- 978 // ---------------------------------------------------------------------------
985 979
986 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 980 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
987 }; 981 };
988 982
989 } // namespace content 983 } // namespace content
990 984
991 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 985 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698