Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Side by Side Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertfix
Patch Set: fixes Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 179 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 190
191 // Tracks whether this RenderViewHost is swapped out, according to its main 191 // Tracks whether this RenderViewHost is swapped out, according to its main
192 // frame RenderFrameHost. 192 // frame RenderFrameHost.
193 void set_is_swapped_out(bool is_swapped_out) { 193 void set_is_swapped_out(bool is_swapped_out) {
194 is_swapped_out_ = is_swapped_out; 194 is_swapped_out_ = is_swapped_out;
195 } 195 }
196 196
197 // TODO(creis): Remove as part of http://crbug.com/418265. 197 // TODO(creis): Remove as part of http://crbug.com/418265.
198 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; } 198 bool is_waiting_for_close_ack() const { return is_waiting_for_close_ack_; }
199 199
200 // Tells the renderer that this RenderView will soon be swapped out, and thus
201 // not to create any new modal dialogs until it happens. This must be done
202 // separately so that the PageGroupLoadDeferrers of any current dialogs are no
203 // longer on the stack when we attempt to swap it out.
204 void SuppressDialogsUntilSwapOut();
205
206 // Tells the renderer process to run the page's unload handler. 200 // Tells the renderer process to run the page's unload handler.
207 // A ClosePage_ACK ack is sent back when the handler execution completes. 201 // A ClosePage_ACK ack is sent back when the handler execution completes.
208 void ClosePage(); 202 void ClosePage();
209 203
210 // Close the page ignoring whether it has unload events registers. 204 // Close the page ignoring whether it has unload events registers.
211 // This is called after the beforeunload and unload events have fired 205 // This is called after the beforeunload and unload events have fired
212 // and the user has agreed to continue with closing the page. 206 // and the user has agreed to continue with closing the page.
213 void ClosePageIgnoringUnloadEvents(); 207 void ClosePageIgnoringUnloadEvents();
214 208
215 // Tells the renderer view to focus the first (last if reverse is true) node. 209 // Tells the renderer view to focus the first (last if reverse is true) node.
(...skipping 203 matching lines...) Expand 10 before | Expand all | Expand 10 after
419 bool render_view_ready_on_process_launch_; 413 bool render_view_ready_on_process_launch_;
420 414
421 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_; 415 base::WeakPtrFactory<RenderViewHostImpl> weak_factory_;
422 416
423 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl); 417 DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
424 }; 418 };
425 419
426 } // namespace content 420 } // namespace content
427 421
428 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_ 422 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/render_frame_host_manager.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698