Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Side by Side Diff: content/renderer/render_view_impl.h

Issue 1849013004: Fix JavaScript alerts from frames with oopif on, after a cross-process click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@alertfix
Patch Set: ordering Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 647 matching lines...) Expand 10 before | Expand all | Expand 10 after
658 void OnSetActive(bool active); 658 void OnSetActive(bool active);
659 void OnSetBackgroundOpaque(bool opaque); 659 void OnSetBackgroundOpaque(bool opaque);
660 void OnExitFullscreen(); 660 void OnExitFullscreen();
661 void OnSetHistoryOffsetAndLength(int history_offset, int history_length); 661 void OnSetHistoryOffsetAndLength(int history_offset, int history_length);
662 void OnSetInitialFocus(bool reverse); 662 void OnSetInitialFocus(bool reverse);
663 void OnSetPageEncoding(const std::string& encoding_name); 663 void OnSetPageEncoding(const std::string& encoding_name);
664 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs); 664 void OnSetRendererPrefs(const RendererPreferences& renderer_prefs);
665 void OnSetWebUIProperty(const std::string& name, const std::string& value); 665 void OnSetWebUIProperty(const std::string& name, const std::string& value);
666 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level); 666 void OnSetZoomLevelForLoadingURL(const GURL& url, double zoom_level);
667 void OnSetZoomLevelForView(bool uses_temporary_zoom_level, double level); 667 void OnSetZoomLevelForView(bool uses_temporary_zoom_level, double level);
668 void OnSuppressDialogsUntilSwapOut();
669 void OnThemeChanged(); 668 void OnThemeChanged();
670 void OnUpdateTargetURLAck(); 669 void OnUpdateTargetURLAck();
671 void OnUpdateWebPreferences(const WebPreferences& prefs); 670 void OnUpdateWebPreferences(const WebPreferences& prefs);
672 void OnSetPageScale(float page_scale_factor); 671 void OnSetPageScale(float page_scale_factor);
673 void OnZoom(PageZoom zoom); 672 void OnZoom(PageZoom zoom);
674 void OnForceRedraw(int request_id); 673 void OnForceRedraw(int request_id);
675 void OnSelectWordAroundCaret(); 674 void OnSelectWordAroundCaret();
676 #if defined(OS_ANDROID) 675 #if defined(OS_ANDROID)
677 void OnUndoScrollFocusedEditableNodeIntoRect(); 676 void OnUndoScrollFocusedEditableNodeIntoRect();
678 void OnUpdateTopControlsState(bool enable_hiding, 677 void OnUpdateTopControlsState(bool enable_hiding,
(...skipping 114 matching lines...) Expand 10 before | Expand all | Expand 10 after
793 792
794 // Loading state ------------------------------------------------------------- 793 // Loading state -------------------------------------------------------------
795 794
796 // The gesture that initiated the current navigation. 795 // The gesture that initiated the current navigation.
797 // TODO(nasko): Move to RenderFrame, as this is per-frame state. 796 // TODO(nasko): Move to RenderFrame, as this is per-frame state.
798 NavigationGesture navigation_gesture_; 797 NavigationGesture navigation_gesture_;
799 798
800 // Used for popups. 799 // Used for popups.
801 bool opened_by_user_gesture_; 800 bool opened_by_user_gesture_;
802 801
803 // Whether we must stop creating nested message loops for modal dialogs until
804 // OnSwapOut is called. This is necessary because modal dialogs have a
805 // PageGroupLoadDeferrer on the stack that interferes with swapping out.
806 bool suppress_dialogs_until_swap_out_;
807
808 // Timer used to delay the updating of nav state (see 802 // Timer used to delay the updating of nav state (see
809 // StartNavStateSyncTimerIfNecessary). 803 // StartNavStateSyncTimerIfNecessary).
810 base::OneShotTimer nav_state_sync_timer_; 804 base::OneShotTimer nav_state_sync_timer_;
811 805
812 // Set of RenderFrame routing IDs for frames that having pending UpdateState 806 // Set of RenderFrame routing IDs for frames that having pending UpdateState
813 // messages to send when the next |nav_state_sync_timer_| fires. 807 // messages to send when the next |nav_state_sync_timer_| fires.
814 std::set<int> frames_with_pending_state_; 808 std::set<int> frames_with_pending_state_;
815 809
816 // Page IDs ------------------------------------------------------------------ 810 // Page IDs ------------------------------------------------------------------
817 // See documentation in RenderView. 811 // See documentation in RenderView.
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
1004 // use the Observer interface to filter IPC messages and receive frame change 998 // use the Observer interface to filter IPC messages and receive frame change
1005 // notifications. 999 // notifications.
1006 // --------------------------------------------------------------------------- 1000 // ---------------------------------------------------------------------------
1007 1001
1008 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl); 1002 DISALLOW_COPY_AND_ASSIGN(RenderViewImpl);
1009 }; 1003 };
1010 1004
1011 } // namespace content 1005 } // namespace content
1012 1006
1013 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_ 1007 #endif // CONTENT_RENDERER_RENDER_VIEW_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698