components/safe_browsing_db/v4_protocol_manager_util.h - Issue 1848973004: Makes V4UpdateProtocolManager auto-schedule update fetching

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/safe_browsing_db/v4_protocol_manager_util.h

Issue 1848973004: Makes V4UpdateProtocolManager auto-schedule update fetching (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@v4_01_

Patch Set: formatting and removed ClearCurrentListStates from test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/safe_browsing_db/database_manager.h ('K') | « components/safe_browsing_db/database_manager.cc ('k') | components/safe_browsing_db/v4_protocol_manager_util.cc » ('j') | components/safe_browsing_db/v4_update_protocol_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/safe_browsing_db/v4_protocol_manager_util.h

diff --git a/components/safe_browsing_db/v4_protocol_manager_util.h b/components/safe_browsing_db/v4_protocol_manager_util.h

index 6671555f4f3c20498f5a233de24d27395ca23ac3..54e8899492f9b5ede72ac13f8131155e6f2748d3 100644

--- a/components/safe_browsing_db/v4_protocol_manager_util.h

+++ b/components/safe_browsing_db/v4_protocol_manager_util.h

@@ -27,6 +27,12 @@ struct V4ProtocolConfig {

// The Google API key.

std::string key_param;

+ // Disable auto-updates using a command line switch?

+ bool disable_auto_update;

+ V4ProtocolConfig();

+ ~V4ProtocolConfig();

};

// The information required to uniquely identify each list the client is

@@ -102,7 +108,7 @@ class V4ProtocolManagerUtil {

size_t* multiplier);

private:

- V4ProtocolManagerUtil() {};

+ V4ProtocolManagerUtil(){};

Nathan Parker 2016/04/01 01:04:52 Is this an auto-format-ism? Seems odd.

vakh (use Gerrit instead) 2016/04/01 02:23:02 Yes, auto-format in vim.

FRIEND_TEST_ALL_PREFIXES(SafeBrowsingV4ProtocolManagerUtilTest,

TestBackOffLogic);

FRIEND_TEST_ALL_PREFIXES(SafeBrowsingV4ProtocolManagerUtilTest,