include/effects/SkMatrixConvolutionImageFilter.h - Issue 1848953002: Image filters: optimize crop rect application

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkMatrixConvolutionImageFilter.h

Issue 1848953002: Image filters: optimize crop rect application (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fixes per review remarks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkMatrixConvolutionImageFilter.h

diff --git a/include/effects/SkMatrixConvolutionImageFilter.h b/include/effects/SkMatrixConvolutionImageFilter.h

index a4abb0d0cf3d9ef4de83edebd1c026147c59e700..092af08f0c84f4a81ecda9b1f074dfe09b7cffa9 100644

--- a/include/effects/SkMatrixConvolutionImageFilter.h

+++ b/include/effects/SkMatrixConvolutionImageFilter.h

@@ -80,7 +80,7 @@ protected:

bool onFilterImageDeprecated(Proxy*, const SkBitmap& src, const Context&,

SkBitmap* result, SkIPoint* loc) const override;

SkIRect onFilterNodeBounds(const SkIRect&, const SkMatrix&, MapDirection) const override;

- bool canComputeFastBounds() const override;

+ bool affectsTransparentBlack() const override;

#if SK_SUPPORT_GPU

bool asFragmentProcessor(GrFragmentProcessor**, GrTexture*, const SkMatrix&,

« no previous file with comments | « include/effects/SkLightingImageFilter.h ('k') | include/effects/SkPaintImageFilter.h » ('j') | no next file with comments »