include/effects/SkColorFilterImageFilter.h - Issue 1848953002: Image filters: optimize crop rect application

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: include/effects/SkColorFilterImageFilter.h

Issue 1848953002: Image filters: optimize crop rect application (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Fixes per review remarks Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: include/effects/SkColorFilterImageFilter.h

diff --git a/include/effects/SkColorFilterImageFilter.h b/include/effects/SkColorFilterImageFilter.h

index 90e6e4bd71a1a8ea487982e061c0cc5b87ac7232..ebe263930d94d1f929edfa6a73cdc86143f4ce73 100644

--- a/include/effects/SkColorFilterImageFilter.h

+++ b/include/effects/SkColorFilterImageFilter.h

@@ -25,7 +25,7 @@ protected:

sk_sp<SkSpecialImage> onFilterImage(SkSpecialImage* source, const Context&,

SkIPoint* offset) const override;

bool onIsColorFilterNode(SkColorFilter**) const override;

- bool canComputeFastBounds() const override;

+ bool affectsTransparentBlack() const override;

private:

SkColorFilterImageFilter(SkColorFilter* cf,

« no previous file with comments | « include/core/SkImageFilter.h ('k') | include/effects/SkLightingImageFilter.h » ('j') | no next file with comments »