Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 1848873002: Force sequential parsing when threads=0. (Closed)

Created:
4 years, 8 months ago by Karl
Modified:
4 years, 8 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Force sequential parsing when threads=0. When threads=0, it doesn't pay to run a parallel parse, since each parallel parse slows down parsing by requiring a copy of bits in the function block. BUG=None R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=3dd127e67b259fbd6d56ae05834b3c2da03e5219

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M src/IceClFlags.h View 1 chunk +3 lines, -0 lines 1 comment Download
M src/IceGlobalContext.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M src/PNaClTranslator.cpp View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Karl
4 years, 8 months ago (2016-03-31 18:00:41 UTC) #3
Jim Stichnoth
lgtm https://codereview.chromium.org/1848873002/diff/1/src/IceClFlags.h File src/IceClFlags.h (right): https://codereview.chromium.org/1848873002/diff/1/src/IceClFlags.h#newcode133 src/IceClFlags.h:133: bool isParseParallel() { const
4 years, 8 months ago (2016-03-31 18:05:09 UTC) #4
Karl
4 years, 8 months ago (2016-03-31 20:22:16 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3dd127e67b259fbd6d56ae05834b3c2da03e5219 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698