src/gpu/vk/GrVkGpu.cpp - Issue 1848833005: First pass at VulkanViewer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/vk/GrVkGpu.cpp

Issue 1848833005: First pass at VulkanViewer (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address comments, plus add GM rendering Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/vk/GrVkGpu.cpp

diff --git a/src/gpu/vk/GrVkGpu.cpp b/src/gpu/vk/GrVkGpu.cpp

index 55f1eae99739220f56014aade32cada9fab47598..dd6c40b054074d1954941400b031e0e7122038c8 100644

--- a/src/gpu/vk/GrVkGpu.cpp

+++ b/src/gpu/vk/GrVkGpu.cpp

@@ -95,10 +95,10 @@ GrVkGpu::GrVkGpu(GrContext* context, const GrContextOptions& options,

callbackCreateInfo.sType = VK_STRUCTURE_TYPE_DEBUG_REPORT_CREATE_INFO_EXT;

callbackCreateInfo.pNext = nullptr;

callbackCreateInfo.flags = VK_DEBUG_REPORT_ERROR_BIT_EXT |

- VK_DEBUG_REPORT_WARNING_BIT_EXT |

+ VK_DEBUG_REPORT_WARNING_BIT_EXT;// |

//VK_DEBUG_REPORT_INFORMATION_BIT_EXT |

//VK_DEBUG_REPORT_DEBUG_BIT_EXT |

- VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT;

+ //VK_DEBUG_REPORT_PERFORMANCE_WARNING_BIT_EXT;

callbackCreateInfo.pfnCallback = &DebugReportCallback;

callbackCreateInfo.pUserData = nullptr;