components/sync_driver/directory_data_type_controller.h - Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/directory_data_type_controller.h

Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix build. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/data_type_manager_impl_unittest.cc ('k') | components/sync_driver/directory_data_type_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/directory_data_type_controller.h

diff --git a/components/sync_driver/directory_data_type_controller.h b/components/sync_driver/directory_data_type_controller.h

index bf68edad8792ada2afffe7a179fa7104d8a38e46..41311fdb1c026203952a3dadaa7e49f457e38b62 100644

--- a/components/sync_driver/directory_data_type_controller.h

+++ b/components/sync_driver/directory_data_type_controller.h

@@ -18,6 +18,11 @@ class DirectoryDataTypeController : public DataTypeController {

// DataTypeController implementation.

bool ShouldLoadModelBeforeConfigure() const override;

+ // Directory based data types don't need to register with backend.

+ // ModelTypeRegistry will create all necessary objects in

+ // SetEnabledDirectoryTypes based on routing info.

+ void RegisterWithBackend(BackendDataTypeConfigurer* configurer) override;

// Directory specific implementation of ActivateDataType with the

// type specific ChangeProcessor and ModelSafeGroup.

// Activates change processing on the controlled data type.