components/sync_driver/non_blocking_data_type_controller.h - Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/non_blocking_data_type_controller.h

Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Sky and Max. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync_driver/glue/sync_backend_registrar.cc ('K') | « components/sync_driver/glue/sync_backend_registrar_unittest.cc ('k') | components/sync_driver/non_blocking_data_type_controller.cc » ('j') | sync/internal_api/public/engine/model_safe_worker.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/non_blocking_data_type_controller.h

diff --git a/components/sync_driver/non_blocking_data_type_controller.h b/components/sync_driver/non_blocking_data_type_controller.h

index 3bb13d9cce81e923211dd0bb949b45523e1a9053..330e82a1928e525604ca66e3c88ccd116c450b50 100644

--- a/components/sync_driver/non_blocking_data_type_controller.h

+++ b/components/sync_driver/non_blocking_data_type_controller.h

@@ -49,6 +49,12 @@ class NonBlockingDataTypeController : public sync_driver::DataTypeController {

// DataTypeController interface.

bool ShouldLoadModelBeforeConfigure() const override;

void LoadModels(const ModelLoadCallback& model_load_callback) override;

+ // Registers non-blocking data type with sync backend. In the process the

+ // activation context is passed to ModelTypeRegistry, where ModelTypeWorker

+ // gets created and connected with ModelTypeProcessor.

+ void RegisterWithBackend(

+ sync_driver::BackendDataTypeConfigurer* configurer) override;

void StartAssociating(const StartCallback& start_callback) override;

void ActivateDataType(

sync_driver::BackendDataTypeConfigurer* configurer) override;