components/sync_driver/data_type_manager_impl_unittest.cc - Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/data_type_manager_impl_unittest.cc

Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments from Sky and Max. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/sync_driver/data_type_manager_impl.cc ('K') | « components/sync_driver/data_type_manager_impl.cc ('k') | components/sync_driver/directory_data_type_controller.h » ('j') | components/sync_driver/glue/sync_backend_registrar.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/data_type_manager_impl_unittest.cc

diff --git a/components/sync_driver/data_type_manager_impl_unittest.cc b/components/sync_driver/data_type_manager_impl_unittest.cc

index 92007112f7bd37053960477c9c9301a236f17df0..eb7dd47131d546de52993c7cfd4b5253cbb6e2d4 100644

--- a/components/sync_driver/data_type_manager_impl_unittest.cc

+++ b/components/sync_driver/data_type_manager_impl_unittest.cc

@@ -1695,10 +1695,12 @@ TEST_F(SyncDataTypeManagerImplTest, DelayConfigureForUSSTypes) {

// Bookmarks model isn't loaded yet and it is required to complete before

// call to configure. Ensure that configure wasn't called.

EXPECT_EQ(0, configurer_.configure_call_count());

+ EXPECT_EQ(0, GetController(BOOKMARKS)->register_with_backend_call_count());

// Finishing model load should trigger configure.

GetController(BOOKMARKS)->SimulateModelLoadFinishing();

EXPECT_EQ(1, configurer_.configure_call_count());

+ EXPECT_EQ(1, GetController(BOOKMARKS)->register_with_backend_call_count());

FinishDownload(*dtm_, ModelTypeSet(), ModelTypeSet());

FinishDownload(*dtm_, ModelTypeSet(BOOKMARKS), ModelTypeSet());