sync/internal_api/public/engine/model_safe_worker_unittest.cc - Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/engine/model_safe_worker_unittest.cc

Issue 1848793006: [Sync] Register USS types with ModelTypeRegistry before download (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« sync/internal_api/public/engine/model_safe_worker.h ('K') | « sync/internal_api/public/engine/model_safe_worker.cc ('k') | sync/internal_api/sync_manager_impl.h » ('j') | sync/internal_api/sync_manager_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/engine/model_safe_worker_unittest.cc

diff --git a/sync/internal_api/public/engine/model_safe_worker_unittest.cc b/sync/internal_api/public/engine/model_safe_worker_unittest.cc

index f2e8c0ee5256db6f25247f777de22e0d9f32005d..b8f4fb2410b1e1c0949198757f2e5f237b999b04 100644

--- a/sync/internal_api/public/engine/model_safe_worker_unittest.cc

+++ b/sync/internal_api/public/engine/model_safe_worker_unittest.cc

@@ -19,7 +19,9 @@ TEST_F(ModelSafeWorkerTest, ModelSafeRoutingInfoToValue) {

routing_info[BOOKMARKS] = GROUP_PASSIVE;

routing_info[NIGORI] = GROUP_UI;

routing_info[PREFERENCES] = GROUP_DB;

+ routing_info[APPS] = GROUP_NON_BLOCKING;

base::DictionaryValue expected_value;

+ expected_value.SetString("Apps", "GROUP_NON_BLOCKING");

expected_value.SetString("Bookmarks", "GROUP_PASSIVE");

expected_value.SetString("Encryption keys", "GROUP_UI");

expected_value.SetString("Preferences", "GROUP_DB");

@@ -30,12 +32,13 @@ TEST_F(ModelSafeWorkerTest, ModelSafeRoutingInfoToValue) {

TEST_F(ModelSafeWorkerTest, ModelSafeRoutingInfoToString) {

ModelSafeRoutingInfo routing_info;

+ routing_info[APPS] = GROUP_NON_BLOCKING;

routing_info[BOOKMARKS] = GROUP_PASSIVE;

routing_info[NIGORI] = GROUP_UI;

routing_info[PREFERENCES] = GROUP_DB;

EXPECT_EQ(

- "{\"Bookmarks\":\"GROUP_PASSIVE\",\"Encryption keys\":\"GROUP_UI\","

- "\"Preferences\":\"GROUP_DB\"}",

+ "{\"Apps\":\"GROUP_NON_BLOCKING\",\"Bookmarks\":\"GROUP_PASSIVE\","

+ "\"Encryption keys\":\"GROUP_UI\",\"Preferences\":\"GROUP_DB\"}",

ModelSafeRoutingInfoToString(routing_info));

}