[Sync] Register USS types with ModelTypeRegistry before download

sync/internal_api/public/engine/model_safe_worker.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_INTERNAL_API_PUBLIC_ENGINE_MODEL_SAFE_WORKER_H_
 #define SYNC_INTERNAL_API_PUBLIC_ENGINE_MODEL_SAFE_WORKER_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 13 matching lines @@
 }  // namespace base
 
 namespace syncer {
 
 // TODO(akalin): Move the non-exported functions in this file to a
 // private header.
 
 typedef base::Callback<enum SyncerError(void)> WorkCallback;
 
 enum ModelSafeGroup {
   GROUP_PASSIVE = 0,   // Models that are just "passively" being synced; e.g.

[skym, 2016/04/01 21:58:22]

Can you update to make it clear that non-blocking types are never passive now?

[pavely, 2016/04/04 17:57:16]

Done.

                        // changes to these models don't need to be pushed to a
                        // native model.
   GROUP_UI,            // Models that live on UI thread and are being synced.
   GROUP_DB,            // Models that live on DB thread and are being synced.
   GROUP_FILE,          // Models that live on FILE thread and are being synced.
   GROUP_HISTORY,       // Models that live on history thread and are being
                        // synced.
   GROUP_PASSWORD,      // Models that live on the password thread and are
                        // being synced.  On windows and linux, this runs on the
                        // DB thread.
+  GROUP_NON_BLOCKING,  // Models that correspond to non-blocking types.

[skym, 2016/04/01 21:58:21]

So as we migrate to USS, we'll be slowly switching everyone from their old
groups into GROUP_NON_BLOCKING?

[pavely, 2016/04/04 17:57:16]

Yes. As we switch data type controllers to be derived from
NonBlockingDataTypeController they will be put into GROUP_NON_BLOCKING group by
SyncBackendRegistrar.

   MODEL_SAFE_GROUP_COUNT,

[skym, 2016/04/01 21:58:22]

Doesn't look like this value is ever used.

[pavely, 2016/04/04 17:57:16]

Done.

 };
 
 SYNC_EXPORT std::string ModelSafeGroupToString(ModelSafeGroup group);
 
 // WorkerLoopDestructionObserver is notified when the thread where it works
 // is going to be destroyed.
 class WorkerLoopDestructionObserver {
  public:
   virtual void OnWorkerLoopDestroyed(ModelSafeGroup group) = 0;
 };
@@ skipping 102 matching lines @@
 SYNC_EXPORT ModelTypeSet GetRoutingInfoTypes(
     const ModelSafeRoutingInfo& routing_info);
 
 SYNC_EXPORT ModelSafeGroup GetGroupForModelType(
     const ModelType type,
     const ModelSafeRoutingInfo& routes);
 
 }  // namespace syncer
 
 #endif  // SYNC_INTERNAL_API_PUBLIC_ENGINE_MODEL_SAFE_WORKER_H_