Issue 1848793004: Fix bash math for `git bash` alias.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1848793004: Fix bash math for `git bash` alias. (Closed)

Created:
4 years, 8 months ago by iannucci

Modified:
4 years, 8 months ago

Reviewers:
dnj, Michael Moss

CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Target Ref:
refs/heads/master

Project:
depot_tools

Visibility:
Public.

More Reviews

Description

Fix bash math for `git bash` alias. Previous calculation was off-by-one. TBR=dnj@chromium.org, mmoss@chromium.org BUG=598956 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299619

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	bootstrap/win/git-bash.template.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

iannucci

4 years, 8 months ago (2016-04-01 01:24:47 UTC) #4

Message was sent while issue was closed.

On 2016/04/01 at 01:24:16, iannucci wrote:
> Committed patchset #1 (id:1) manually as 299619.

TBR'd because these scripts are 'sticky' and so anyone who updated to a bad one
would have to delete it to get the new version.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages