third_party/WebKit/Source/core/page/FocusController.cpp - Issue 1848753002: Consider slots' tabindex in focus navigation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 1848753002: Consider slots' tabindex in focus navigation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Override tabIndex() in HTMLSlotElement Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/page/FocusController.cpp

diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp

index df65ba7a8410a5cf58d5eca15f233de3dd7edd54..452c936bf3c547e29fc8d772c97cf753c5096a7c 100644

--- a/third_party/WebKit/Source/core/page/FocusController.cpp

+++ b/third_party/WebKit/Source/core/page/FocusController.cpp

@@ -337,7 +337,7 @@ inline bool isShadowHostDelegatesFocus(const Element& element)

inline int adjustedTabIndex(Element& element)

{

- return isNonFocusableFocusScopeOwner(element) ? 0 : element.tabIndex();

+ return isNonKeyboardFocusableShadowHost(element) || isShadowInsertionPointFocusScopeOwner(element) ? 0 : element.tabIndex();

hayato 2016/04/01 05:56:57 It would be better to use parenthesis. return (is

yuzuchan 2016/04/01 06:06:56 Done.

}

inline bool shouldVisit(Element& element)