Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 1848733002: Subzero: Refine the memory usage report with -szstats . (Closed)

Created:
4 years, 8 months ago by Jim Stichnoth
Modified:
4 years, 8 months ago
Reviewers:
Eric Holk, Karl, sehr, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Refine the memory usage report with -szstats . The problem is that the memory usage that comes from the -track-memory option is not very well-defined (it's a hidden LLVM option after all). It gives an OK sense of memory growth over time, but sometimes we really want to know how much CFG-local arena memory was allocated for a particular function. To help with this, we add another row to the stats output, giving the MB size of the CFG arena at the end of translating the method. BUG= https://bugs.chromium.org/p/nativeclient/issues/detail?id=4366 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=b5eee3d7bc9dfb37535e414051d177af1a517bfc

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Simplify the interface #

Patch Set 4 : Bug fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M src/IceCompiler.cpp View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M src/IceGlobalContext.h View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M src/IceGlobalContext.cpp View 1 2 3 5 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
4 years, 8 months ago (2016-03-31 17:56:34 UTC) #3
Karl
lgtm
4 years, 8 months ago (2016-03-31 18:04:06 UTC) #4
Jim Stichnoth
4 years, 8 months ago (2016-03-31 18:05:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
b5eee3d7bc9dfb37535e414051d177af1a517bfc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698