Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 184873004: Update resource requests to remove redundant frame ID. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/resource_request_info.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 209b20bd42ea3ed1cf75a673d3d1c1ef659e9f85..d2874f8571b8e830d8f3e76874f9a48b21d9345a 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -855,7 +855,7 @@ blink::WebPlugin* RenderFrameImpl::CreatePlugin(
blink::WebFrame* frame,
const WebPluginInfo& info,
const blink::WebPluginParams& params) {
- // TODO(creis): |frame| is different from |frame_| here. This seems wrong.
+ DCHECK_EQ(frame_, frame);
#if defined(ENABLE_PLUGINS)
bool pepper_plugin_was_registered = false;
scoped_refptr<PluginModule> pepper_module(PluginModule::Create(
@@ -895,7 +895,7 @@ void RenderFrameImpl::OnChildFrameProcessGone() {
blink::WebPlugin* RenderFrameImpl::createPlugin(
blink::WebFrame* frame,
const blink::WebPluginParams& params) {
- // TODO(creis): |frame| is different from |frame_| here. This seems wrong.
+ DCHECK_EQ(frame_, frame);
blink::WebPlugin* plugin = NULL;
if (GetContentClient()->renderer()->OverrideCreatePlugin(
this, frame, params, &plugin)) {
@@ -1680,9 +1680,6 @@ void RenderFrameImpl::willSendRequest(
should_replace_current_entry =
navigation_state->should_replace_current_entry();
}
- // TODO(creis): Remove the second routing ID from the request, now that we
- // use routing IDs instead of frame IDs. (This is a viral change, so I'm
- // splitting it into multiple CLs.)
int parent_routing_id = frame->parent() ?
FromWebFrame(frame->parent())->GetRoutingID() : -1;
request.setExtraData(
@@ -1691,7 +1688,6 @@ void RenderFrameImpl::willSendRequest(
was_after_preconnect_request,
routing_id_,
(frame == top_frame),
- routing_id_,
GURL(frame->document().securityOrigin().toString()),
frame->parent() == top_frame,
parent_routing_id,
« no previous file with comments | « content/public/browser/resource_request_info.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698