Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 18487003: Turn UInt32 analysis into a proper HPhase. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer
Modified:
7 years, 5 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Turn UInt32 analysis into a proper HPhase. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15441

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix typos. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+256 lines, -236 lines) Patch
M src/hydrogen.h View 2 chunks +11 lines, -1 line 0 comments Download
M src/hydrogen.cc View 3 chunks +2 lines, -223 lines 0 comments Download
A + src/hydrogen-uint32-analysis.h View 2 chunks +14 lines, -12 lines 0 comments Download
A src/hydrogen-uint32-analysis.cc View 1 1 chunk +227 lines, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Benedikt Meurer
7 years, 5 months ago (2013-07-02 08:49:38 UTC) #1
Jakob Kummerow
LGTM. While you're here, you can fix a few typos :-) https://codereview.chromium.org/18487003/diff/1/src/hydrogen-uint32-analysis.cc File src/hydrogen-uint32-analysis.cc (right): ...
7 years, 5 months ago (2013-07-02 09:16:40 UTC) #2
Benedikt Meurer
7 years, 5 months ago (2013-07-02 10:53:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r15441 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698