Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/heap.h

Issue 18487002: Properly cleanup the transcendental subcaches. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2934 matching lines...) Expand 10 before | Expand all | Expand 10 after
2945 // For evaluating value. 2945 // For evaluating value.
2946 friend class TranscendentalCache; 2946 friend class TranscendentalCache;
2947 2947
2948 DISALLOW_COPY_AND_ASSIGN(SubCache); 2948 DISALLOW_COPY_AND_ASSIGN(SubCache);
2949 }; 2949 };
2950 2950
2951 TranscendentalCache() { 2951 TranscendentalCache() {
2952 for (int i = 0; i < kNumberOfCaches; ++i) caches_[i] = NULL; 2952 for (int i = 0; i < kNumberOfCaches; ++i) caches_[i] = NULL;
2953 } 2953 }
2954 2954
2955 ~TranscendentalCache() {
2956 for (int i = 0; i < kNumberOfCaches; ++i) delete caches_[i];
2957 }
2958
2955 // Used to create an external reference. 2959 // Used to create an external reference.
2956 inline Address cache_array_address(); 2960 inline Address cache_array_address();
2957 2961
2958 // Instantiation 2962 // Instantiation
2959 friend class Isolate; 2963 friend class Isolate;
2960 // Inline implementation of the caching. 2964 // Inline implementation of the caching.
2961 friend class TranscendentalCacheStub; 2965 friend class TranscendentalCacheStub;
2962 // Allow access to the caches_ array as an ExternalReference. 2966 // Allow access to the caches_ array as an ExternalReference.
2963 friend class ExternalReference; 2967 friend class ExternalReference;
2964 2968
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
3074 DisallowHeapAllocation no_allocation; // i.e. no gc allowed. 3078 DisallowHeapAllocation no_allocation; // i.e. no gc allowed.
3075 3079
3076 private: 3080 private:
3077 DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer); 3081 DISALLOW_IMPLICIT_CONSTRUCTORS(PathTracer);
3078 }; 3082 };
3079 #endif // DEBUG 3083 #endif // DEBUG
3080 3084
3081 } } // namespace v8::internal 3085 } } // namespace v8::internal
3082 3086
3083 #endif // V8_HEAP_H_ 3087 #endif // V8_HEAP_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698