Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1848623003: S390: [turbofan] Frame elision for code stubs. (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: [turbofan] Frame elision for code stubs. Port 53d51c52f3754fe0e7decacba4277e58cf9fb5a4 Original commit message: Removed Frame::needs_frame and the function-wide logic using it in favor of FrameAccessState::has_frame, which can be set on a more granular level, and driving it block by block. R=mtrofin@chromium.org, joransiu@ca.ibm.com, mbrandy@us.ibm.com, michael_dawson@ca.ibm.com, rmcilroy@chromium.org BUG=v8:4533 LOG=N Committed: https://crrev.com/3cb6a22a1ec7fe3f4720823037505c92a1d1fc1e Cr-Commit-Position: refs/heads/master@{#35177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -24 lines) Patch
M src/compiler/s390/code-generator-s390.cc View 10 chunks +21 lines, -22 lines 0 comments Download
M src/s390/macro-assembler-s390.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-03-31 17:18:46 UTC) #1
Mircea Trofin
lgtm
4 years, 8 months ago (2016-03-31 17:30:01 UTC) #2
JoranSiu
lgtm
4 years, 8 months ago (2016-03-31 17:35:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1848623003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1848623003/1
4 years, 8 months ago (2016-03-31 17:39:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-03-31 18:39:29 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 18:40:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3cb6a22a1ec7fe3f4720823037505c92a1d1fc1e
Cr-Commit-Position: refs/heads/master@{#35177}

Powered by Google App Engine
This is Rietveld 408576698